[Bug 8078] [review] Shortcircuiting does not work as expected

[bu...@spamassassin.apache.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=8078

Henrik Krohns <ap...@hege.li> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|FIXED                       |---
            Summary|Shortcircuiting does not    |[review] Shortcircuiting
                   |work as expected            |does not work as expected
             Status|RESOLVED                    |REOPENED

--- Comment #5 from Henrik Krohns <ap...@hege.li> ---
Ok I'll reopen this myself per list discussion to try to move things along.

Looking at do_meta_tests(), I think it doesn't have any dependencies to
anything aside from start_rules/Reuse, which I guess is never used with
shortcircuiting. So not running it looks fine, and should prevent evaluating
any rules with unexpected meta results. I'd leave the priority -2000 changes
around in case someone is using older trunk.

I would add deadline check, and probably move this before start_rules is
called, since we don't want to start anything more?

sub do_meta_tests {
  my ($self, $pms, $priority, $finish) = @_;

  return if $pms->{deadline_exceeded} || $pms->{shortcircuited};


+1, vote to commit?

-- 
You are receiving this mail because:
You are the assignee for the bug.