You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "Fred Ji (JIRA)" <ji...@apache.org> on 2017/11/30 18:38:00 UTC

[jira] [Resolved] (SAMZA-1412) remove mockito-all from the dependency

     [ https://issues.apache.org/jira/browse/SAMZA-1412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fred Ji resolved SAMZA-1412.
----------------------------
    Resolution: Fixed

> remove mockito-all from the dependency
> --------------------------------------
>
>                 Key: SAMZA-1412
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1412
>             Project: Samza
>          Issue Type: Improvement
>            Reporter: Fred Ji
>            Assignee: Fred Ji
>             Fix For: 0.14.0
>
>
> It is bad practice to use mockito-all because mockito-all include some of dependency's code in the package, which makes the dependency resolving not work expected and causes conflicting issues. For example, mockito-all include the code for hamcrest which may make the dependency point to the class in mockito-all instead of hamcrest-core, if there are any incompatible change in hamcrest, it will cause failure.  
> We should remove mockito-all and use mockito-core in the dependency for samza. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)