[GitHub] [tvm] rkimball edited a comment on pull request #6953: Add retry to sockets on EINTR error

[GitBox <gi...@apache.org>]

rkimball edited a comment on pull request #6953:
URL: https://github.com/apache/tvm/pull/6953#issuecomment-738957120


   @areusch Thank you for the research and help
   There are two uses of socket.h within tvm:
   1) In tvm_runtime as the python RPC server via runtime/rpc/rpc_socket_impl.cc
   2) In cpp_rpc as the cpp RPC server via apps/cpp_rpc/rpc_server.cc
   
   We could add a flag which is passed from the users of the user rpc_socket_impl to socket.h indicating how it is supposed to handle EINTR. Perhaps we could pass an optional interrupt handler function to the socket which would be called on EINTR and use a returned bool to either retry or abort.
   I have not seen EINTR while using the cpp RPC server but have seen it with python.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org