[GitHub] [beam] Abacn commented on a diff in pull request #25970: Use wheels for Dataflow postcommit tests

["Abacn (via GitHub)" <gi...@apache.org>]

Abacn commented on code in PR #25970:
URL: https://github.com/apache/beam/pull/25970#discussion_r1153468041


##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -2785,15 +2785,70 @@ class BeamModulePlugin implements Plugin<Project> {
       // distribution tarball generated by :sdks:python:sdist.
       project.configurations { distTarBall }
 
+      // Create a task to install Beam python SDK locally before running tests on
+      // Google cloud platform. The task depends on ':sdks:python:sdist' project
+      // for the tarball file.
+      // For compatible systems (Linux amd64), a 'sdistReuseWheel' system property
+      // can be provided to re-use the wheel built in this task (by configuring
+      // `--sdk_location` pipeine option in test tasks).
       def installGcpTest = project.tasks.register('installGcpTest')  {
         dependsOn setupVirtualenv
         dependsOn ':sdks:python:sdist'
+
+        // if host system wheel compatible with dataflow runner
+        def compatibleWithDataflow = ("amd64".equalsIgnoreCase(System.getProperty("os.arch")) &&

Review Comment:
   Yes this is simpler when moving to GitHub Action. The PostCommit can just add a prerequisite step of building wheels.
   
   Currently, build wheel is a GitHub Action workflow (https://github.com/apache/beam/blob/master/.github/workflows/build_wheels.yml) and PostCommits are still Jenkins tasks and cannot make use of the former.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org