You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/09/11 06:49:47 UTC

[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #6450: [WINDOWS][MSVC] Fix MSVC warnings

junrushao1994 commented on a change in pull request #6450:
URL: https://github.com/apache/incubator-tvm/pull/6450#discussion_r486809195



##########
File path: CMakeLists.txt
##########
@@ -109,6 +109,22 @@ if(MSVC)
       endif(${flag_var} MATCHES "/MD")
     endforeach(flag_var)
   endif()
+  # Disable common MSVC warnings
+  # Integer conversion warnings(e.g. int64 to int)
+  add_compile_options(/wd4244)

Review comment:
       we might revisit to cmake file to avoid global flags, but for now it is good enough




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org