You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/05 09:12:43 UTC
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 opened a new pull request, #1398: Fix slcd_trapezoids.cxx:38:5: error: array designators are a C99 extension
xiaoxiang781216 opened a new pull request, #1398:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1398
## Summary
Reported here: https://github.com/apache/incubator-nuttx/pull/7391
## Impact
Style change
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1398: Fix slcd_trapezoids.cxx:38:5: error: array designators are a C99 extension
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #1398:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1398#discussion_r1015178882
##########
include/graphics/twm4nx/ciconmgr.hxx:
##########
@@ -77,7 +77,7 @@ namespace Twm4Nx
NXWidgets::CNxString m_name; /**< The Icon Manager name */
FAR struct SWindowEntry *m_head; /**< Head of the window list */
FAR struct SWindowEntry *m_tail; /**< Tail of the window list */
- FAR struct CWindow *m_window; /**< Parent window */
+ FAR CWindow * m_window; /**< Parent window */
FAR NXWidgets::CButtonArray *m_buttons; /**< The contained button array */
Review Comment:
```suggestion
FAR CWindow *m_window; /**< Parent window */
FAR NXWidgets::CButtonArray *m_buttons; /**< The contained button array */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1398: Fix slcd_trapezoids.cxx:38:5: error: array designators are a C99 extension
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1398:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1398#discussion_r1015318331
##########
include/graphics/twm4nx/ciconmgr.hxx:
##########
@@ -77,7 +77,7 @@ namespace Twm4Nx
NXWidgets::CNxString m_name; /**< The Icon Manager name */
FAR struct SWindowEntry *m_head; /**< Head of the window list */
FAR struct SWindowEntry *m_tail; /**< Tail of the window list */
- FAR struct CWindow *m_window; /**< Parent window */
+ FAR CWindow * m_window; /**< Parent window */
FAR NXWidgets::CButtonArray *m_buttons; /**< The contained button array */
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko merged pull request #1398: Fix slcd_trapezoids.cxx:38:5: error: array designators are a C99 extension
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #1398:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1398
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1398: Fix slcd_trapezoids.cxx:38:5: error: array designators are a C99 extension
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #1398:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1398#issuecomment-1304735343
@pkarashchenko could you review this patch? https://github.com/apache/incubator-nuttx/pull/7391 need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org