[GitHub] [incubator-druid] zhenxiao commented on a change in pull request #8809: Prohibit Futures.addCallback(Future, Callback)

[GitBox <gi...@apache.org>]

zhenxiao commented on a change in pull request #8809: Prohibit Futures.addCallback(Future, Callback)
URL: https://github.com/apache/incubator-druid/pull/8809#discussion_r343408775
 
 

 ##########
 File path: core/src/main/java/org/apache/druid/java/util/common/concurrent/ListenableFutures.java
 ##########
 @@ -61,15 +61,19 @@ public void onFailure(Throwable t)
           {
             finalFuture.setException(t);
           }
-        });
+        },
+            // The callback is non-blocking and quick, so it's OK to schedule it using directExecutor()
 
 Review comment:
   seems this is the indentation suggested when compile the code. Anyway, let me refactor to make it more readable

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org