You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streams.apache.org by robdouglas <gi...@git.apache.org> on 2014/09/16 20:50:13 UTC
[GitHub] incubator-streams pull request: STREAMS-176 | Added ability to ove...
GitHub user robdouglas opened a pull request:
https://github.com/apache/incubator-streams/pull/86
STREAMS-176 | Added ability to override functions that could prove usefu...
...l to downstream developers
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robdouglas/incubator-streams STREAMS-176
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-streams/pull/86.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #86
----
commit 95509b08df3cf1c4132ca131d102acd1513a6514
Author: Robert Douglas <rd...@w2odigital.com>
Date: 2014-09-16T18:48:17Z
STREAMS-176 | Added ability to override functions that could prove useful to downstream developers
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-176 | Added ability to ove...
Posted by robdouglas <gi...@git.apache.org>.
Github user robdouglas commented on the pull request:
https://github.com/apache/incubator-streams/pull/86#issuecomment-56579678
There is a TwitterStreamProviderTest, however it looks like it doesn't actually enforce any assertions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-176 | Added ability to ove...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-streams/pull/86
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-176 | Added ability to ove...
Posted by mfranklin <gi...@git.apache.org>.
Github user mfranklin commented on the pull request:
https://github.com/apache/incubator-streams/pull/86#issuecomment-58197220
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-176 | Added ability to ove...
Posted by mfranklin <gi...@git.apache.org>.
Github user mfranklin commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/86#discussion_r17988007
--- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java ---
@@ -116,11 +115,11 @@ public void startStream() {
executor.shutdown();
}
- protected boolean shouldContinuePulling(List<Status> statuses) {
+ public boolean shouldContinuePulling(List<Status> statuses) {
--- End diff --
Why mark this public, it was already protected?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-176 | Added ability to ove...
Posted by rbnks <gi...@git.apache.org>.
Github user rbnks commented on the pull request:
https://github.com/apache/incubator-streams/pull/86#issuecomment-56196453
Are there any unit tests associated with these changes that need to be updated or created?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-176 | Added ability to ove...
Posted by mfranklin <gi...@git.apache.org>.
Github user mfranklin commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/86#discussion_r18521763
--- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java ---
@@ -116,11 +115,11 @@ public void startStream() {
executor.shutdown();
}
- protected boolean shouldContinuePulling(List<Status> statuses) {
+ public boolean shouldContinuePulling(List<Status> statuses) {
--- End diff --
@robdouglas Any reason?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-streams pull request: STREAMS-176 | Added ability to ove...
Posted by robdouglas <gi...@git.apache.org>.
Github user robdouglas commented on a diff in the pull request:
https://github.com/apache/incubator-streams/pull/86#discussion_r18523292
--- Diff: streams-contrib/streams-provider-twitter/src/main/java/org/apache/streams/twitter/provider/TwitterTimelineProvider.java ---
@@ -116,11 +115,11 @@ public void startStream() {
executor.shutdown();
}
- protected boolean shouldContinuePulling(List<Status> statuses) {
+ public boolean shouldContinuePulling(List<Status> statuses) {
--- End diff --
In the event that an individual needs to override the TwitterTimelineProvider and use those overridden methods in an overridden version of TwitterTimelineProviderTask, they would need to be marked public in order to be visible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---