[GitHub] [flink] AHeise commented on a change in pull request #17367: [FLINK-24382][metrics] Do not compute recordsOut metric in SinkOperat…

[GitBox <gi...@apache.org>]

AHeise commented on a change in pull request #17367:
URL: https://github.com/apache/flink/pull/17367#discussion_r721306027



##########
File path: flink-connectors/flink-connector-files/src/main/java/org/apache/flink/connector/file/sink/writer/FileWriter.java
##########
@@ -85,17 +86,21 @@
 
     private final OutputFileConfig outputFileConfig;
 
+    private final Counter recordsOutCounter;
+
     /**
      * A constructor creating a new empty bucket manager.
      *
      * @param basePath The base path for our buckets.
+     * @param recordsOutCounter denoting the number records already written
      * @param bucketAssigner The {@link BucketAssigner} provided by the user.
      * @param bucketFactory The {@link FileWriterBucketFactory} to be used to create buckets.
      * @param bucketWriter The {@link BucketWriter} to be used when writing data.
      * @param rollingPolicy The {@link RollingPolicy} as specified by the user.
      */
     public FileWriter(
             final Path basePath,
+            final Counter recordsOutCounter,

Review comment:
       I propose to pass the whole metric group instead. We will need it anyways for advanced metrics.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org