You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2018/04/25 19:41:00 UTC
[jira] [Commented] (LUCENE-8277) Better validate CodecReaders in
addIndexes
[ https://issues.apache.org/jira/browse/LUCENE-8277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452947#comment-16452947 ]
Michael McCandless commented on LUCENE-8277:
--------------------------------------------
+1; it's otherwise a way for "corrupted" indices to be created.
> Better validate CodecReaders in addIndexes
> ------------------------------------------
>
> Key: LUCENE-8277
> URL: https://issues.apache.org/jira/browse/LUCENE-8277
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Priority: Minor
>
> The discussion at LUCENE-8264 made me wonder that we should apply the same checks to addIndexes(CodecReader) that we apply at index time if the input reader is not a SegmentReader such as:
> - positions are less than the maximum position
> - offsets are going forward
> And maybe also check that the API is implemented correctly, eg. terms, doc ids and positions are returned in order?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org