You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by Oliver-Rainer Wittmann <or...@googlemail.com> on 2013/09/06 17:28:14 UTC

[request for review] - Solution for regressions 122862, 122870, 122955, 123161 and 123163

Hi,

I had worked on a fix to solve some regressions [1][2][3][4][5] 
introduced into Calc in AOO 4.0.0 by changes for issue 12666 [6].
The patch is attached to issue 122862 [1] and I have committed it on 
trunk, rev. 1520602

Probably, the one or the other can try one of the next build bot 
installation sets from trunk and check the fixed issues and issue 12666.

I would like to have the regressions solved for AOO 4.0.1.
If my fix works fine (may be with the one or the other smaller 
correction), we can go for it.
Otherwise, I will revert the changes made for issue 12666 for AOO 4.0.1 
to get the regressions fixed for AOO 4.0.1
Issue 12666 will then be solved for AOO 4.1

Thanks in advance.

[1] https://issues.apache.org/ooo/show_bug.cgi?id=122862
[2] https://issues.apache.org/ooo/show_bug.cgi?id=122870
[3] https://issues.apache.org/ooo/show_bug.cgi?id=122955
[4] https://issues.apache.org/ooo/show_bug.cgi?id=123161
[5] https://issues.apache.org/ooo/show_bug.cgi?id=123163
[6] https://issues.apache.org/ooo/show_bug.cgi?id=12666


Best regards, Oliver.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Re: [request for review] - Solution for regressions 122862, 122870, 122955, 123161 and 123163

Posted by Oliver-Rainer Wittmann <or...@googlemail.com>.
Hi,

On 09.09.2013 23:39, Kay Schenk wrote:
> On Fri, Sep 6, 2013 at 8:28 AM, Oliver-Rainer Wittmann <
> orwittmann@googlemail.com> wrote:
>
>> Hi,
>>
>> I had worked on a fix to solve some regressions [1][2][3][4][5] introduced
>> into Calc in AOO 4.0.0 by changes for issue 12666 [6].
>> The patch is attached to issue 122862 [1] and I have committed it on
>> trunk, rev. 1520602
>>
>> Probably, the one or the other can try one of the next build bot
>> installation sets from trunk and check the fixed issues and issue 12666.
>>
>> I would like to have the regressions solved for AOO 4.0.1.
>> If my fix works fine (may be with the one or the other smaller
>> correction), we can go for it.
>> Otherwise, I will revert the changes made for issue 12666 for AOO 4.0.1 to
>> get the regressions fixed for AOO 4.0.1
>> Issue 12666 will then be solved for AOO 4.1
>>
>> Thanks in advance.
>>
>> [1] https://issues.apache.org/ooo/**show_bug.cgi?id=122862<https://issues.apache.org/ooo/show_bug.cgi?id=122862>
>> [2] https://issues.apache.org/ooo/**show_bug.cgi?id=122870<https://issues.apache.org/ooo/show_bug.cgi?id=122870>
>> [3] https://issues.apache.org/ooo/**show_bug.cgi?id=122955<https://issues.apache.org/ooo/show_bug.cgi?id=122955>
>> [4] https://issues.apache.org/ooo/**show_bug.cgi?id=123161<https://issues.apache.org/ooo/show_bug.cgi?id=123161>
>> [5] https://issues.apache.org/ooo/**show_bug.cgi?id=123163<https://issues.apache.org/ooo/show_bug.cgi?id=123163>
>> [6] https://issues.apache.org/ooo/**show_bug.cgi?id=12666<https://issues.apache.org/ooo/show_bug.cgi?id=12666>
>>
>>
>> Best regards, Oliver.
>>
>
> I tried the sample doc with the latest linux-32 nightly build from
> buildbot, and made some comments on 122862. Then, I noticed this seemed to
> only be Windows 7.
>
> Anyway, all good with Linux-32 but maybe this is not related to  the
> issue.  :/
>

Thanks for the review.
The defect is independent of the operating system - I just forgot to 
adjust the issue data.

Best regards, Oliver.
>
>> ------------------------------**------------------------------**---------
>> To unsubscribe, e-mail: dev-unsubscribe@openoffice.**apache.org<de...@openoffice.apache.org>
>> For additional commands, e-mail: dev-help@openoffice.apache.org
>>
>>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@openoffice.apache.org
For additional commands, e-mail: dev-help@openoffice.apache.org


Re: [request for review] - Solution for regressions 122862, 122870, 122955, 123161 and 123163

Posted by Kay Schenk <ka...@gmail.com>.
On Fri, Sep 6, 2013 at 8:28 AM, Oliver-Rainer Wittmann <
orwittmann@googlemail.com> wrote:

> Hi,
>
> I had worked on a fix to solve some regressions [1][2][3][4][5] introduced
> into Calc in AOO 4.0.0 by changes for issue 12666 [6].
> The patch is attached to issue 122862 [1] and I have committed it on
> trunk, rev. 1520602
>
> Probably, the one or the other can try one of the next build bot
> installation sets from trunk and check the fixed issues and issue 12666.
>
> I would like to have the regressions solved for AOO 4.0.1.
> If my fix works fine (may be with the one or the other smaller
> correction), we can go for it.
> Otherwise, I will revert the changes made for issue 12666 for AOO 4.0.1 to
> get the regressions fixed for AOO 4.0.1
> Issue 12666 will then be solved for AOO 4.1
>
> Thanks in advance.
>
> [1] https://issues.apache.org/ooo/**show_bug.cgi?id=122862<https://issues.apache.org/ooo/show_bug.cgi?id=122862>
> [2] https://issues.apache.org/ooo/**show_bug.cgi?id=122870<https://issues.apache.org/ooo/show_bug.cgi?id=122870>
> [3] https://issues.apache.org/ooo/**show_bug.cgi?id=122955<https://issues.apache.org/ooo/show_bug.cgi?id=122955>
> [4] https://issues.apache.org/ooo/**show_bug.cgi?id=123161<https://issues.apache.org/ooo/show_bug.cgi?id=123161>
> [5] https://issues.apache.org/ooo/**show_bug.cgi?id=123163<https://issues.apache.org/ooo/show_bug.cgi?id=123163>
> [6] https://issues.apache.org/ooo/**show_bug.cgi?id=12666<https://issues.apache.org/ooo/show_bug.cgi?id=12666>
>
>
> Best regards, Oliver.
>

I tried the sample doc with the latest linux-32 nightly build from
buildbot, and made some comments on 122862. Then, I noticed this seemed to
only be Windows 7.

Anyway, all good with Linux-32 but maybe this is not related to  the
issue.  :/


> ------------------------------**------------------------------**---------
> To unsubscribe, e-mail: dev-unsubscribe@openoffice.**apache.org<de...@openoffice.apache.org>
> For additional commands, e-mail: dev-help@openoffice.apache.org
>
>


-- 
-------------------------------------------------------------------------------------------------
MzK

"Truth is stranger than fiction, but it is because Fiction is obliged
 to stick to possibilities. Truth isn't."
                             -- "Following the Equator", Mark Twain