[jira] [Comment Edited] (CAMEL-11509) Cannot set content type with parameters without specifying charset

["onder sezgin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CAMEL-11509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16074730#comment-16074730 ] 

onder sezgin edited comment on CAMEL-11509 at 7/5/17 1:27 PM:
--------------------------------------------------------------

even if you pass like this,

{noformat}
.setHeader("Content-Type", constant("application/json;odata=verbose"))
{noformat}

the endpoint sees the content-type like "application/json; odata=verbose".

please notice the space after ;

that's why there is a trick in this line;

https://github.com/apache/camel/pull/1805#discussion-diff-125638439R92


was (Author: onders):
even if you pass like this,

{noformat}
.setHeader("Content-Type", constant("application/json;odata=verbose"))
{noformat}

the endpoint sees the content-type like "application/json; odata=verbose".

please notice the space after ;

> Cannot set content type with parameters without specifying charset
> ------------------------------------------------------------------
>
>                 Key: CAMEL-11509
>                 URL: https://issues.apache.org/jira/browse/CAMEL-11509
>             Project: Camel
>          Issue Type: Bug
>          Components: camel-http4
>    Affects Versions: 2.19.0, 2.19.1
>            Reporter: Steffen F.
>            Assignee: onder sezgin
>             Fix For: 2.19.2, 2.20.0
>
>
> When setting a content type that does not contain a charset parameter, for example this:
> {noformat}
> .setHeader("Content-Type", constant("application/json;odata=verbose"))
> {noformat}
> the route will fail with the following exception:
> {noformat}
> java.lang.IllegalArgumentException: MIME type may not contain reserved characters
> 	at org.apache.http.util.Args.check(Args.java:36)
> 	at org.apache.http.entity.ContentType.create(ContentType.java:206)
> 	at org.apache.http.entity.ContentType.create(ContentType.java:218)
> 	at org.apache.camel.component.http4.HttpProducer.createRequestEntity(HttpProducer.java:511)
> {noformat}
> although this is clearly a valid content type according to the RFC: https://tools.ietf.org/html/rfc2045#section-5.1
> This only affects version 2.19+, because in version 4.4.6 of the httpcomponents-core library, they changed the behavior of {{create}} to check the mime type for semicolons, which it previously didn't. If we, however, also use a charset parameter, you will call the {{parse}} method instead:
> {noformat}
> if (contentTypeString != null) {
>     if (contentTypeString.indexOf("charset") > 0) {
>         contentType = ContentType.parse(contentTypeString);
>     } else {
>         contentType = ContentType.create(contentTypeString);
>     }
> }
> {noformat}
> There can be all kind of different parameters, though. Instead of checking for charset, it should rather check for the existence of a semicolon. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)