Re: [PR] [CELEBORN-1360] Ensure that a client cannot push or fetch data belonging to a different application [celeborn]

["RexXiong (via GitHub)" <gi...@apache.org>]

RexXiong commented on PR #2431:
URL: https://github.com/apache/celeborn/pull/2431#issuecomment-2029425837

   > > Besides pushing and fetching data, I think we also need to enforce authentication checks for the following RPCs: from LifecycleManager to Worker (ReserveSlots, CommitFiles, DestroyWorkerSlots), and from LifecycleManager to Master (HeartbeatFromApplication, RequestSlots, ApplicationLost, PbUnregisterShuffle, etc.)
   > 
   > @RexXiong This doesn't seem straightforward right now. The Master and Worker use the RPC layer which doesn't exposes the `TransportClient` or the `channel` and the `NettyRpcHandler` doesn't know about appIds in the messages. My suggestion is that we protect the data, that is, pushes and fetches right now. I can create a follow-up jira to see how we can check this for these control plane messages.
   
   Make sense to address this in a follow-up JIRA. Additionally, concerning the issue of the RPC layer not exposing the client, I suggest adding TransportClient into NettyRpcCallContext


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org