You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2019/06/25 13:07:22 UTC
[GitHub] [kylin] hit-lacus commented on a change in pull request #710:
KYLIN-4046 Refine JDBC Source(source.default=8)
hit-lacus commented on a change in pull request #710: KYLIN-4046 Refine JDBC Source(source.default=8)
URL: https://github.com/apache/kylin/pull/710#discussion_r297177296
##########
File path: core-metadata/src/main/java/org/apache/kylin/metadata/model/PartitionDesc.java
##########
@@ -184,19 +185,26 @@ public TblColRef getPartitionTimeColumnRef() {
// ============================================================================
public static interface IPartitionConditionBuilder {
- String buildDateRangeCondition(PartitionDesc partDesc, ISegment seg, SegmentRange segRange);
+ String buildDateRangeCondition(PartitionDesc partDesc, ISegment seg, SegmentRange segRange, Function<TblColRef, String> quoteFunc);
}
public static class DefaultPartitionConditionBuilder implements IPartitionConditionBuilder, Serializable {
@Override
- public String buildDateRangeCondition(PartitionDesc partDesc, ISegment seg, SegmentRange segRange) {
+ public String buildDateRangeCondition(PartitionDesc partDesc, ISegment seg, SegmentRange segRange, Function<TblColRef, String> quoteFunc) {
long startInclusive = (Long) segRange.start.v;
long endExclusive = (Long) segRange.end.v;
TblColRef partitionDateColumn = partDesc.getPartitionDateColumnRef();
TblColRef partitionTimeColumn = partDesc.getPartitionTimeColumnRef();
+ if (partitionDateColumn != null) {
+ partitionDateColumn.setQuotedFunc(quoteFunc);
Review comment:
One for partition**Date**Column, another for partition**Time**Column
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services