You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "rishabhdaim (via GitHub)" <gi...@apache.org> on 2026/10/16 07:29:28 UTC

[PR] JCRVLT-860 : reject backslash and control characters in PackageId validation [jackrabbit-filevault]

rishabhdaim opened a new pull request, #443:
URL: https://github.com/apache/jackrabbit-filevault/pull/443

   ## Summary
   
   Reject backslashes and ISO control characters in package ID group segments, names, and versions. Backport the validation change to 3.2.x while preserving the branch's Java 7 compatibility and existing TestCase conventions.
   
   ## Changes
   
   - Extend PackageId name validation to reject backslashes and ISO control characters.
   - Add five regression tests covering valid IDs and invalid characters in each package ID component.
   
   ## Test Plan
   
   - [x] Compile and run PackageIdTest independently with the branch's dependencies: all 30 tests pass.
   - [x] Confirm the production patch matches the source change and the tests differ only in their branch-specific JUnit adaptation.
   - [ ] Maven targeted test run: blocked during test compilation by missing ConfigurationPolicy and inaccessible Group in unrelated test sources.
   
   ## Links
   
   - JIRA: https://issues.apache.org/jira/browse/JCRVLT-860
   
   Co-Authored-By: GitHub Copilot <co...@github.com>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] JCRVLT-860 : reject backslash and control characters in PackageId validation [jackrabbit-filevault]

Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on PR #443:
URL: https://github.com/apache/jackrabbit-filevault/pull/443#issuecomment-6213611094

   ...so minimally the misleading stuff in the description should be removed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] JCRVLT-860 : reject backslash and control characters in PackageId validation [jackrabbit-filevault]

Posted by "rishabhdaim (via GitHub)" <gi...@apache.org>.
rishabhdaim merged PR #443:
URL: https://github.com/apache/jackrabbit-filevault/pull/443


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] JCRVLT-860 : reject backslash and control characters in PackageId validation [jackrabbit-filevault]

Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on PR #443:
URL: https://github.com/apache/jackrabbit-filevault/pull/443#issuecomment-6213552355

   > while preserving the branch's Java 7 compatibility 
   
   We shouldn't do extra work here (was there???)
   , and just require Java 8.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] JCRVLT-860 : reject backslash and control characters in PackageId validation [jackrabbit-filevault]

Posted by "reschke (via GitHub)" <gi...@apache.org>.
reschke commented on PR #443:
URL: https://github.com/apache/jackrabbit-filevault/pull/443#issuecomment-6213583084

   >Maven targeted test run: blocked during test compilation by missing ConfigurationPolicy and inaccessible Group in unrelated test sources.
   
   That's not supposed to happen when a JDK < 14 is used.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] JCRVLT-860 : reject backslash and control characters in PackageId validation [jackrabbit-filevault]

Posted by "rishabhdaim (via GitHub)" <gi...@apache.org>.
rishabhdaim commented on PR #443:
URL: https://github.com/apache/jackrabbit-filevault/pull/443#issuecomment-6213695665

   > ...so minimally the misleading stuff in the description should be removed.
   
   done


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org