[GitHub] [incubator-doris] yiguolei commented on a diff in pull request #9792: [Improvement] optimize scannode concurrency query performance in vectorized engine.

[GitBox <gi...@apache.org>]

yiguolei commented on code in PR #9792:
URL: https://github.com/apache/incubator-doris/pull/9792#discussion_r884138206


##########
be/src/vec/exec/volap_scan_node.cpp:
##########
@@ -554,8 +576,11 @@ Block* VOlapScanNode::_alloc_block(bool& get_free_block) {
 int VOlapScanNode::_start_scanner_thread_task(RuntimeState* state, int block_per_scanner) {
     std::list<VOlapScanner*> olap_scanners;
     int assigned_thread_num = _running_thread;
-    size_t max_thread = std::min(_volap_scanners.size(),
-                                 static_cast<size_t>(config::doris_scanner_thread_pool_thread_num));
+    size_t max_thread = config::doris_scanner_queue_size;

Review Comment:
   The previous logic is wrong, For example, if assiged thread num = 13 and volap_scanner.size = 5.
   thread_slot_num = std::min(thread_slot_num, max_thread - assigned_thread_num);
                   if (thread_slot_num <= 0) {
                       thread_slot_num = 1;
                   }
   This logic will set thread_slot_num = 1. Will not put as many as task to queue. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org