You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/17 03:44:28 UTC

[GitHub] [pulsar] HQebupt commented on a diff in pull request #16097: [improve][broker]correct the semantics of loadBalancerHistoryResourcePercentage

HQebupt commented on code in PR #16097:
URL: https://github.com/apache/pulsar/pull/16097#discussion_r899737004


##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -2050,7 +2050,7 @@ public class ServiceConfiguration implements PulsarConfiguration {
             category = CATEGORY_LOAD_BALANCER,
             doc = "Resource history Usage Percentage When adding new resource usage info"
     )
-    private double loadBalancerHistoryResourcePercentage = 0.9;
+    private int loadBalancerHistoryResourcePercentage = 90;

Review Comment:
   Can we keep the field double type ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org