You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2020/12/14 13:01:16 UTC
[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2436: Add da1469x uart driver
apache-mynewt-bot removed a comment on pull request #2436:
URL: https://github.com/apache/mynewt-core/pull/2436#issuecomment-744392138
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### hw/drivers/uart/uart_da1469x/src/uart_da1469x.c
<details>
```diff
@@ -291,7 +291,7 @@
break;
case UART_PARITY_EVEN:
reg |= UART2_UART2_LCR_REG_UART_EPS_Msk;
- /* no break */
+ /* no break */
case UART_PARITY_ODD:
reg |= UART2_UART2_LCR_REG_UART_PEN_Msk;
break;
@@ -493,7 +493,7 @@
uart->UART2_RBR_THR_DLL_REG = byte;
while (!(uart->UART2_USR_REG & UART2_UART2_USR_REG_UART_TFE_Msk) ||
- (uart->UART2_USR_REG & UART2_UART2_USR_REG_UART_BUSY_Msk)) {
+ (uart->UART2_USR_REG & UART2_UART2_USR_REG_UART_BUSY_Msk)) {
/* Wait until FIFO is empty and UART finished tx */
}
}
@@ -504,7 +504,7 @@
struct da1469x_uart_dev *dev = (struct da1469x_uart_dev *)odev;
struct da1469x_uart_cfg *cfg = arg;
- if (cfg->pin_rx >=0) {
+ if (cfg->pin_rx >= 0) {
os_callout_init(&dev->wakeup_callout, os_eventq_dflt_get(),
da1469x_uart_on_wakeup_callout_cb, dev);
```
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org