You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/06/10 09:41:53 UTC

[GitHub] [tvm] Hzfengsy commented on a change in pull request #8215: [TVMSCRIPT] Fix printing of rank 0 buffer access

Hzfengsy commented on a change in pull request #8215:
URL: https://github.com/apache/tvm/pull/8215#discussion_r649024990



##########
File path: python/tvm/script/intrin.py
##########
@@ -180,6 +185,11 @@ def opaque_axis(begin, end, span):
     return get_axis(begin, end, "opaque", span)
 
 
+@register
+def Select(cond, if_body, else_body, span):  # pylint: disable=invalid-name

Review comment:
       Thanks for the explanation. But I still personally prefer `select` since most of the existing Python APIs are using lower case (e.g. `tir.min`, `tir. if_then_else`)
   
   On the other side, `Select` looks OK for me if you still persist on it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org