[GitHub] [james-project] chibenwa commented on a change in pull request #753: JAMES-3674 : Support password salting and hash scheme upgrading

[GitBox <gi...@apache.org>]

chibenwa commented on a change in pull request #753:
URL: https://github.com/apache/james-project/pull/753#discussion_r752260048



##########
File path: server/data/data-library/src/main/java/org/apache/james/user/lib/model/Algorithm.java
##########
@@ -27,63 +27,53 @@
 public class Algorithm {
 
     public enum HashingMode {
-        LEGACY(LEGACY_FACTORY),
-        DEFAULT(DEFAULT_FACTORY);
+        PLAIN,
+        SALTED,
+        LEGACY,
+        LEGACY_SALTED;

Review comment:
       👍 let's keep legacy salted as it help the original contributor ;-) this topic was btw alredy discussed on the mailing list.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org