[GitHub] matthiasblaesing commented on a change in pull request #799: [NETBEANS-1074] Module Review web.jsf12

[GitBox <gi...@apache.org>]

matthiasblaesing commented on a change in pull request #799: [NETBEANS-1074] Module Review web.jsf12
URL: https://github.com/apache/incubator-netbeans/pull/799#discussion_r214967638
 
 

 ##########
 File path: web.jsf12/nbproject/project.properties
 ##########
 @@ -15,13 +15,5 @@
 # specific language governing permissions and limitations
 # under the License.
 
-# release.external/jsf-1.2.zip!/jsf-1.2/commons-beanutils.jar=modules/ext/jsf-1_2/commons-beanutils.jar
-# release.external/jsf-1.2.zip!/jsf-1.2/commons-collections.jar=modules/ext/jsf-1_2/commons-collections.jar
-# release.external/jsf-1.2.zip!/jsf-1.2/commons-digester.jar=modules/ext/jsf-1_2/commons-digester.jar
-# release.external/jsf-1.2.zip!/jsf-1.2/commons-logging.jar=modules/ext/jsf-1_2/commons-logging.jar
-release.external/jsf-1.2.zip!/jsf-1.2/jsf-api.jar=modules/ext/jsf-1_2/jsf-api.jar
-# release.external/jsf-1.2.zip!/jsf-1.2/jsf-impl.jar=modules/ext/jsf-1_2/jsf-impl.jar
-release.external/jsf-1.2.zip!/jsf-1.2/LICENSE-APACHE.txt=modules/ext/jsf-1_2/LICENSE-APACHE.txt
-release.external/jsf-1.2.zip!/jsf-1.2/LICENSE.TXT=modules/ext/jsf-1_2/LICENSE.TXT
-release.external/jsf-1.2.zip!/jsf-1.2/THIRDPARTYLICENSEREADME.txt=modules/ext/jsf-1_2/THIRDPARTYLICENSEREADME.txt
+release.external/jsf-api-1.2_05.jar=modules/ext/jsf-1_2/jsf-api-1.2_05.jar
 
 Review comment:
   You are changing the filename and this in turn means, that you need to adjust the `project.xml`, as that file references the file. In this case, I would not change the filename, as the important version information is coded into the subdirectory.
   
   The `project.xml` is also missing the `binary-origin` header (that was the case already before your changes), please also add it (see `libs.amazon/nbproject/project.xml` for an example.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists