Re: [PR] MINIFICPP-2708 Controller Service C API [nifi-minifi-cpp]

["szaszm (via GitHub)" <gi...@apache.org>]

szaszm commented on code in PR #2096:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2096#discussion_r3064692690


##########
minifi-api/include/minifi-c/minifi-c.h:
##########
@@ -153,6 +155,12 @@ typedef struct MinifiProcessorMetadata {
   MinifiLogger* logger;  // borrowed reference, live until the processor is live
 } MinifiProcessorMetadata;
 
+typedef struct MinifiControllerServiceMetadata {
+  MinifiStringView uuid;
+  MinifiStringView name;
+  MinifiLogger* logger;  // borrowed reference, live until the controller service is live

Review Comment:
   Is this nullable?



##########
Extensions.md:
##########
@@ -77,7 +77,9 @@ extern "C" void MinifiInitCppExtension(MinifiExtension* extension, MinifiConfig*
     .deinit = nullptr,
     .user_data = nullptr,
     .processors_count = 0,
-    .processors_ptr = nullptr
+    .processors_ptr = nullptr,
+    .controller_services_count = 0,
+    .controller_services_ptr = nullptr,

Review Comment:
   I think the count and ptr members were deleted in #2150 , maybe this needs a rebase 



##########
libminifi/include/utils/CProcessor.h:
##########
@@ -63,18 +64,18 @@ class CProcessor : public minifi::core::ProcessorApi {
   CProcessor(CProcessorClassDescription class_description, minifi::core::ProcessorMetadata metadata)
       : class_description_(std::move(class_description)),
         metrics_extension_(std::make_shared<CProcessorMetricsWrapper>(*this)) {
-    metadata_ = metadata;
+    metadata_ = std::move(metadata);

Review Comment:
   this could be moved to the member initializer list



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org