You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/08/30 18:03:31 UTC

svn commit: r1892739 - /pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/destination/

Author: tilman
Date: Mon Aug 30 18:03:31 2021
New Revision: 1892739

URL: http://svn.apache.org/viewvc?rev=1892739&view=rev
Log:
PDFBOX-4892: always grow to maximum, as suggested by valerybokov; remove super()

Modified:
    pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/destination/PDPageFitDestination.java
    pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/destination/PDPageFitHeightDestination.java
    pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/destination/PDPageFitRectangleDestination.java
    pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/destination/PDPageFitWidthDestination.java
    pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/destination/PDPageXYZDestination.java

Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/destination/PDPageFitDestination.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/destination/PDPageFitDestination.java?rev=1892739&r1=1892738&r2=1892739&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/destination/PDPageFitDestination.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/destination/PDPageFitDestination.java Mon Aug 30 18:03:31 2021
@@ -41,7 +41,6 @@ public class PDPageFitDestination extend
      */
     public PDPageFitDestination()
     {
-        super();
         array.growToSize(2);
         array.setName( 1, TYPE );
 

Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/destination/PDPageFitHeightDestination.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/destination/PDPageFitHeightDestination.java?rev=1892739&r1=1892738&r2=1892739&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/destination/PDPageFitHeightDestination.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/destination/PDPageFitHeightDestination.java Mon Aug 30 18:03:31 2021
@@ -41,7 +41,6 @@ public class PDPageFitHeightDestination
      */
     public PDPageFitHeightDestination()
     {
-        super();
         array.growToSize(3);
         array.setName( 1, TYPE );
 
@@ -103,7 +102,7 @@ public class PDPageFitHeightDestination
      */
     public void setFitBoundingBox( boolean fitBoundingBox )
     {
-        array.growToSize( 2 );
+        array.growToSize(3);
         if( fitBoundingBox )
         {
             array.setName( 1, TYPE_BOUNDED );

Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/destination/PDPageFitRectangleDestination.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/destination/PDPageFitRectangleDestination.java?rev=1892739&r1=1892738&r2=1892739&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/destination/PDPageFitRectangleDestination.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/destination/PDPageFitRectangleDestination.java Mon Aug 30 18:03:31 2021
@@ -37,7 +37,6 @@ public class PDPageFitRectangleDestinati
      */
     public PDPageFitRectangleDestination()
     {
-        super();
         array.growToSize(6);
         array.setName( 1, TYPE );
 
@@ -71,7 +70,7 @@ public class PDPageFitRectangleDestinati
      */
     public void setLeft( int x )
     {
-        array.growToSize( 3 );
+        array.growToSize(6);
         if( x == -1 )
         {
             array.set(2, null);

Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/destination/PDPageFitWidthDestination.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/destination/PDPageFitWidthDestination.java?rev=1892739&r1=1892738&r2=1892739&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/destination/PDPageFitWidthDestination.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/destination/PDPageFitWidthDestination.java Mon Aug 30 18:03:31 2021
@@ -42,7 +42,6 @@ public class PDPageFitWidthDestination e
      */
     public PDPageFitWidthDestination()
     {
-        super();
         array.growToSize(3);
         array.setName( 1, TYPE );
 
@@ -105,7 +104,7 @@ public class PDPageFitWidthDestination e
      */
     public void setFitBoundingBox( boolean fitBoundingBox )
     {
-        array.growToSize( 2 );
+        array.growToSize(3);
         if( fitBoundingBox )
         {
             array.setName( 1, TYPE_BOUNDED );

Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/destination/PDPageXYZDestination.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/destination/PDPageXYZDestination.java?rev=1892739&r1=1892738&r2=1892739&view=diff
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/destination/PDPageXYZDestination.java (original)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/interactive/documentnavigation/destination/PDPageXYZDestination.java Mon Aug 30 18:03:31 2021
@@ -41,7 +41,6 @@ public class PDPageXYZDestination extend
      */
     public PDPageXYZDestination()
     {
-        super();
         array.growToSize(5);
         array.setName( 1, TYPE );
     }
@@ -74,7 +73,7 @@ public class PDPageXYZDestination extend
      */
     public void setLeft( int x )
     {
-        array.growToSize( 3 );
+        array.growToSize(5);
         if( x == -1 )
         {
             array.set(2, null);
@@ -103,7 +102,7 @@ public class PDPageXYZDestination extend
      */
     public void setTop( int y )
     {
-        array.growToSize( 4 );
+        array.growToSize(5);
         if( y == -1 )
         {
             array.set(3, null);