You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Jason van Zyl <jv...@maven.org> on 2004/02/17 16:02:22 UTC

Re: cvs commit: maven-components/maven-project/src/java/org/apache/maven/project DefaultMavenProjectBuilder.java

On Tue, 2004-02-17 at 04:38, evenisse@apache.org wrote:
>   -        result.put( "basedir", descriptorDirectory.getPath() );
>   +        result.put( "basedir", descriptorDirectory.getAbsolutePath() );

Should File.getAbsolutePath() always be used to make sure things work
correctly on Windows? There are a few more places to fix if this is the
case.

> 
> -- 
> jvz.
> 
> Jason van Zyl
> jason@maven.org
> http://maven.apache.org
> 
> happiness is like a butterfly: the more you chase it, the more it will
> elude you, but if you turn your attention to other things, it will come
> and sit softly on your shoulder ...
> 
>  -- Thoreau 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: cvs commit:maven-components/maven-project/src/java/org/apache/maven/projectDefaultMavenProjectBuilder.java

Posted by Jason van Zyl <jv...@maven.org>.
On Tue, 2004-02-17 at 10:23, Emmanuel Venisse wrote:

> OK, I finished. I can build any projects and run all tests :-)
> Emmanuel

Awesome, now I'll fire up my g4 and try this on OSX. Then I've got a big
pile of notes to push out. It's dead simple now to make simple POJO
components for Maven2 but the relationships between what a goal is and
what a plugin is need to be clearly defined.

Anyway, I'm going to flip back to the 1.0 code and see if I can get it
out over the next couple of days.

> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org

-- 
jvz.

Jason van Zyl
jason@maven.org
http://maven.apache.org

happiness is like a butterfly: the more you chase it, the more it will
elude you, but if you turn your attention to other things, it will come
and sit softly on your shoulder ...

 -- Thoreau 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: cvs commit:maven-components/maven-project/src/java/org/apache/maven/projectDefaultMavenProjectBuilder.java

Posted by Emmanuel Venisse <em...@venisse.net>.
>
> ----- Original Message ----- 
> From: "Jason van Zyl" <jv...@maven.org>
> To: "Maven Developers List" <de...@maven.apache.org>
> Sent: Tuesday, February 17, 2004 4:02 PM
> Subject: Re: cvs
>
commit:maven-components/maven-project/src/java/org/apache/maven/projectDefau
> ltMavenProjectBuilder.java
>
>
> > On Tue, 2004-02-17 at 04:38, evenisse@apache.org wrote:
> > >   -        result.put( "basedir", descriptorDirectory.getPath() );
> > >   +        result.put( "basedir",
> descriptorDirectory.getAbsolutePath() );
> >
> > Should File.getAbsolutePath() always be used to make sure things work
> > correctly on Windows? There are a few more places to fix if this is the
> > case.
>
> Yes, If I haven't this, I have in basedir (with extended projects) path
like
> this :
> D:\directory_project\.\src\test-input\a\.\src\test-input\a\..\project.xml
>
> Actually, only surefire doesn't works fine. Surefire receive a basedir
> equals to #basedir and not a correct path. I fix this now.

OK, I finished. I can build any projects and run all tests :-)
Emmanuel


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: cvs commit:maven-components/maven-project/src/java/org/apache/maven/projectDefaultMavenProjectBuilder.java

Posted by Emmanuel Venisse <em...@venisse.net>.
----- Original Message ----- 
From: "Jason van Zyl" <jv...@maven.org>
To: "Maven Developers List" <de...@maven.apache.org>
Sent: Tuesday, February 17, 2004 4:02 PM
Subject: Re: cvs
commit:maven-components/maven-project/src/java/org/apache/maven/projectDefau
ltMavenProjectBuilder.java


> On Tue, 2004-02-17 at 04:38, evenisse@apache.org wrote:
> >   -        result.put( "basedir", descriptorDirectory.getPath() );
> >   +        result.put( "basedir",
descriptorDirectory.getAbsolutePath() );
>
> Should File.getAbsolutePath() always be used to make sure things work
> correctly on Windows? There are a few more places to fix if this is the
> case.

Yes, If I haven't this, I have in basedir (with extended projects) path like
this :
D:\directory_project\.\src\test-input\a\.\src\test-input\a\..\project.xml

Actually, only surefire doesn't works fine. Surefire receive a basedir
equals to #basedir and not a correct path. I fix this now.


>
> >
> > -- 
> > jvz.
> >
> > Jason van Zyl
> > jason@maven.org
> > http://maven.apache.org
> >
> > happiness is like a butterfly: the more you chase it, the more it will
> > elude you, but if you turn your attention to other things, it will come
> > and sit softly on your shoulder ...
> >
> >  -- Thoreau
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org