You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Pradeep Agrawal <pr...@gmail.com> on 2019/02/21 04:01:12 UTC

Re: Review Request 69655: RANGER-2317 : make Ranger buildable on newer JDKs

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69655/#review213014
-----------------------------------------------------------



Tested Ranger installation in OpenJDK 10, 11 and Oracle JDK-11.

Observations: Below mentioned java arguments needs to be removed from the ranger-admin-services.sh file for the successful start of ranger admin service as they are deprecated.

UseGCLogFileRotation
NumberOfGCLogFiles=10
GCLogFileSize=1m
PrintHeapAtGC
PrintGCDateStamps

- Pradeep Agrawal


On Jan. 7, 2019, 8:30 p.m., Zsombor Gegesy wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69655/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2019, 8:30 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-2317
>     https://issues.apache.org/jira/browse/RANGER-2317
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Upgrade librarias to become compatible with JDK11, and JAXB and other librarias to the modules, and exclude jdk.tools. 
> (These modules was previously part of the JDK, now they are independent). 
> Add JDK10/11 to the travis build - with excluding the Hive tests, as we can't even start the Hive tests on JDK 9 - because internal Hive code cast the system classloader to URLClassLoader.
> Removed one empty test class file, which triggered test failures with newer mockito version.
> 
> 
> Diffs
> -----
> 
>   .travis.yml b38b892bd 
>   enunciate.xml f64af1a56 
>   hbase-agent/pom.xml c044ef0c3 
>   kms/pom.xml 043c67fde 
>   knox-agent/pom.xml 0c45c84ba 
>   plugin-solr/pom.xml 619cc9ebd 
>   pom.xml 2a2540a0d 
>   ranger-hbase-plugin-shim/pom.xml 9ed0aebe8 
>   ranger-solr-plugin-shim/pom.xml 46b78218a 
>   security-admin/pom.xml 14cafb4b2 
>   security-admin/src/test/java/org/apache/ranger/plugin/store/RangerDBStore.java cd5bb384e 
>   ugsync/src/test/java/org/apache/ranger/unixusersync/process/TestUnixUserGroupBuilder.java 2118c8430 
> 
> 
> Diff: https://reviews.apache.org/r/69655/diff/2/
> 
> 
> Testing
> -------
> 
> Tested resulting binaries locally on JDK 8, to stay the same as previously. All the dependency change was either in test code, or in Maven plugin config, or has 'provided' scope.
> 
> Tested on Travis that build is succesfull in 4 JVMs - oraclejdk8/oraclejdk11/openjdk10/openjdk11:
> https://travis-ci.org/gzsombor/ranger/builds/474559352
> 
> 
> Thanks,
> 
> Zsombor Gegesy
> 
>