You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Hari Sankar Sivarama Subramaniyan <hs...@hortonworks.com> on 2014/06/11 23:23:12 UTC
Review Request 22478: HIVE-7188 sum(if()) returns wrong results with
vectorization
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22478/
-----------------------------------------------------------
Review request for hive, Gopal V and Jitendra Pandey.
Bugs: HIVE-7188
https://issues.apache.org/jira/browse/HIVE-7188
Repository: hive-git
Description
-------
ColAndCol.evaluate() is incorrectly implemented. Needed to rewrite the evaluate(). Also added junit tests.
Diffs
-----
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/ColAndCol.java cb2a952
ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorLogicalExpressions.java 3df7c14
Diff: https://reviews.apache.org/r/22478/diff/
Testing
-------
Thanks,
Hari Sankar Sivarama Subramaniyan
Re: Review Request 22478: HIVE-7188 sum(if()) returns wrong results with
vectorization
Posted by Hari Sankar Sivarama Subramaniyan <hs...@hortonworks.com>.
> On June 11, 2014, 11:25 p.m., Jitendra Pandey wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/ColAndCol.java, line 118
> > <https://reviews.apache.org/r/22478/diff/1/?file=607639#file607639line118>
> >
> > Please confirm hive semantics that
> > NULL AND FALSE is FALSE and not NULL.
Looked at GenericUDFOPAnd. evaluate(), it will return FALSE if either one of the arguments is FALSE. So this is consistent with non-vectorized behavior.
- Hari Sankar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22478/#review45438
-----------------------------------------------------------
On June 11, 2014, 9:23 p.m., Hari Sankar Sivarama Subramaniyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22478/
> -----------------------------------------------------------
>
> (Updated June 11, 2014, 9:23 p.m.)
>
>
> Review request for hive, Gopal V and Jitendra Pandey.
>
>
> Bugs: HIVE-7188
> https://issues.apache.org/jira/browse/HIVE-7188
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> ColAndCol.evaluate() is incorrectly implemented. Needed to rewrite the evaluate(). Also added junit tests.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/ColAndCol.java cb2a952
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorLogicalExpressions.java 3df7c14
>
> Diff: https://reviews.apache.org/r/22478/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari Sankar Sivarama Subramaniyan
>
>
Re: Review Request 22478: HIVE-7188 sum(if()) returns wrong results with
vectorization
Posted by Jitendra Pandey <jn...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22478/#review45438
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/ColAndCol.java
<https://reviews.apache.org/r/22478/#comment80300>
Please confirm hive semantics that
NULL AND FALSE is FALSE and not NULL.
- Jitendra Pandey
On June 11, 2014, 9:23 p.m., Hari Sankar Sivarama Subramaniyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22478/
> -----------------------------------------------------------
>
> (Updated June 11, 2014, 9:23 p.m.)
>
>
> Review request for hive, Gopal V and Jitendra Pandey.
>
>
> Bugs: HIVE-7188
> https://issues.apache.org/jira/browse/HIVE-7188
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> ColAndCol.evaluate() is incorrectly implemented. Needed to rewrite the evaluate(). Also added junit tests.
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/ColAndCol.java cb2a952
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/expressions/TestVectorLogicalExpressions.java 3df7c14
>
> Diff: https://reviews.apache.org/r/22478/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Hari Sankar Sivarama Subramaniyan
>
>