[GitHub] [arrow-datafusion] houqp commented on a change in pull request #1751: [split/1] split datafusion-common module

[GitBox <gi...@apache.org>]

houqp commented on a change in pull request #1751:
URL: https://github.com/apache/arrow-datafusion/pull/1751#discussion_r800265069



##########
File path: datafusion/Cargo.toml
##########
@@ -43,13 +43,14 @@ simd = ["arrow/simd"]
 crypto_expressions = ["md-5", "sha2", "blake2", "blake3"]
 regex_expressions = ["regex"]
 unicode_expressions = ["unicode-segmentation"]
-pyarrow = ["pyo3", "arrow/pyarrow"]
+pyarrow = ["pyo3", "arrow/pyarrow", "datafusion-common/pyarrow"]
 # Used for testing ONLY: causes all values to hash to the same value (test for collisions)
 force_hash_collisions = []
 # Used to enable the avro format
-avro = ["avro-rs", "num-traits"]
+avro = ["avro-rs", "num-traits", "datafusion-common/avro"]
 
 [dependencies]
+datafusion-common = { path = "../datafusion-common" }

Review comment:
       I think we will also add a version here, otherwise we won't be able to publish datafusion crate to crates.io.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org