[GitHub] [doris] wangshuo128 commented on pull request #11073: [enhance](nereids): use optional for combine()

[GitBox <gi...@apache.org>]

wangshuo128 commented on PR #11073:
URL: https://github.com/apache/doris/pull/11073#issuecomment-1192087816

   The current implementation looks reasonable to me. 
   A literal true/false predicate for empty input conjunctive/disjunctive predicates is right. It has no effect on the input data of the filter when the input predicate list is empty. 
   And you could check if the result is boolean literal, which has not much different from using an optional result.
   A boolean literal result is much better because it has the opportunity to be optimized by boolean value rewrite rules further.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org