You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/02/08 00:26:35 UTC
[GitHub] [iceberg-docs] samredai opened a new pull request #40: Fix weights for landing-page for left/right alternations
samredai opened a new pull request #40:
URL: https://github.com/apache/iceberg-docs/pull/40
The theme has some logic that alternates the items on the landing-page based on the weights. It uses [modBool](https://gohugo.io/functions/math/) from hugo and for some reason seems to break with larger numbers. Using simpler digits here fixes it.
cc: @rdblue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] samredai commented on pull request #40: Fix weights for landing-page for left/right alternations
Posted by GitBox <gi...@apache.org>.
samredai commented on pull request #40:
URL: https://github.com/apache/iceberg-docs/pull/40#issuecomment-1032086667
Thought about this for 2 more seconds and it makes sense why this wasn't working with 100, 200, 300 etc. It just takes the modulus of the weight and 2 to decide left vs. right. So this PR is the right fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg-docs] rdblue merged pull request #40: Fix weights for landing-page for left/right alternations
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #40:
URL: https://github.com/apache/iceberg-docs/pull/40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org