You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/02/04 01:50:31 UTC
Review Request: Updated configure.ac to loop through possible JAVA_CPPFLAGS
options per environment.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9280/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Description
-------
Using the magic of autoconf macros and some standard shell I hope that this will be an extensible way to add possible JAVA_CPPFLAGS to for various environments and setups. Next I'd love to tie JAVA_HOME, JAVA_CPPFLAGS, and JAVA_LDFLAGS even better so that we don't use a jni.h from one path but a libjvm.so from a different path. :(
Note that some of the constructs used here are macros and are thus expanded via autoconf/autoreconf (i.e., configure.ac -> configure) versus at runtime (i.e., ../configure). Thus, any "list" like features from m4 are only usable in ways that force us to write slightly redundant code (e.g., multiple while loops, see the diff).
Diffs
-----
configure.ac 553b9e163ef312eb8f97f9bd380b3c2b5350bd5b
Diff: https://reviews.apache.org/r/9280/diff/
Testing
-------
Thanks,
Benjamin Hindman
Re: Review Request: Updated configure.ac to loop through possible
JAVA_CPPFLAGS options per environment.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On Feb. 4, 2013, 6:13 p.m., Ben Mahler wrote:
> > configure.ac, line 228
> > <https://reviews.apache.org/r/9280/diff/1/?file=254989#file254989line228>
> >
> > Can you add a comment beside $2 and $1 here, indicating that they are performing the success/failure actions?
Done.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9280/#review16053
-----------------------------------------------------------
On Feb. 4, 2013, 12:50 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9280/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2013, 12:50 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Description
> -------
>
> Using the magic of autoconf macros and some standard shell I hope that this will be an extensible way to add possible JAVA_CPPFLAGS to for various environments and setups. Next I'd love to tie JAVA_HOME, JAVA_CPPFLAGS, and JAVA_LDFLAGS even better so that we don't use a jni.h from one path but a libjvm.so from a different path. :(
>
> Note that some of the constructs used here are macros and are thus expanded via autoconf/autoreconf (i.e., configure.ac -> configure) versus at runtime (i.e., ../configure). Thus, any "list" like features from m4 are only usable in ways that force us to write slightly redundant code (e.g., multiple while loops, see the diff).
>
>
> Diffs
> -----
>
> configure.ac 553b9e163ef312eb8f97f9bd380b3c2b5350bd5b
>
> Diff: https://reviews.apache.org/r/9280/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Updated configure.ac to loop through possible
JAVA_CPPFLAGS options per environment.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9280/#review16053
-----------------------------------------------------------
Ship it!
Very nice!
I'd even consider pushing the OS check / while loops inside the macro as well and moving it to an m4 file. But perhaps not at this point.
configure.ac
<https://reviews.apache.org/r/9280/#comment34355>
Can you add a comment beside $2 and $1 here, indicating that they are performing the success/failure actions?
- Ben Mahler
On Feb. 4, 2013, 12:50 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9280/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2013, 12:50 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Description
> -------
>
> Using the magic of autoconf macros and some standard shell I hope that this will be an extensible way to add possible JAVA_CPPFLAGS to for various environments and setups. Next I'd love to tie JAVA_HOME, JAVA_CPPFLAGS, and JAVA_LDFLAGS even better so that we don't use a jni.h from one path but a libjvm.so from a different path. :(
>
> Note that some of the constructs used here are macros and are thus expanded via autoconf/autoreconf (i.e., configure.ac -> configure) versus at runtime (i.e., ../configure). Thus, any "list" like features from m4 are only usable in ways that force us to write slightly redundant code (e.g., multiple while loops, see the diff).
>
>
> Diffs
> -----
>
> configure.ac 553b9e163ef312eb8f97f9bd380b3c2b5350bd5b
>
> Diff: https://reviews.apache.org/r/9280/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request: Updated configure.ac to loop through possible
JAVA_CPPFLAGS options per environment.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9280/
-----------------------------------------------------------
(Updated Feb. 8, 2013, 5:54 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
Addressed comments.
Description
-------
Using the magic of autoconf macros and some standard shell I hope that this will be an extensible way to add possible JAVA_CPPFLAGS to for various environments and setups. Next I'd love to tie JAVA_HOME, JAVA_CPPFLAGS, and JAVA_LDFLAGS even better so that we don't use a jni.h from one path but a libjvm.so from a different path. :(
Note that some of the constructs used here are macros and are thus expanded via autoconf/autoreconf (i.e., configure.ac -> configure) versus at runtime (i.e., ../configure). Thus, any "list" like features from m4 are only usable in ways that force us to write slightly redundant code (e.g., multiple while loops, see the diff).
Diffs (updated)
-----
configure.ac 553b9e163ef312eb8f97f9bd380b3c2b5350bd5b
Diff: https://reviews.apache.org/r/9280/diff/
Testing
-------
Thanks,
Benjamin Hindman