You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2018/10/26 04:01:01 UTC

[GitHub] spark pull request #22823: [SPARK-25676][SQL][TEST] Improve BenchmarkWideTab...

Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22823#discussion_r228399871
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala ---
    @@ -910,12 +910,14 @@ class CodegenContext {
         val blocks = new ArrayBuffer[String]()
         val blockBuilder = new StringBuilder()
         var length = 0
    +    val splitThreshold =
    +      SQLConf.get.getConfString("spark.testing.codegen.splitThreshold", "1024").toInt
    --- End diff --
    
    In this case, we need advice from the right person. :)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org