You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/11/17 01:32:36 UTC
Review Request 15628: Fixed the thread-safety of process::ID::generate.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15628/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
Repository: mesos-git
Description
-------
It seems that now that the slave uses async, this was sufficient to expose the lack of thread-safety in process::ID::generate. The ExamplesTest.TestFramework was crashing on a flaky basis for this reason.
Diffs
-----
3rdparty/libprocess/src/process.cpp 9952dd1505bcfc2f99e4349196e69fc8328a827c
Diff: https://reviews.apache.org/r/15628/diff/
Testing
-------
make check with many iterations of ExamplesTest.TestFramework, which previously was crashing on a flaky basis.
Thanks,
Ben Mahler
Re: Review Request 15628: Fixed the thread-safety of process::ID::generate.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15628/#review29050
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Nov. 17, 2013, 12:37 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15628/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2013, 12:37 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-815
> https://issues.apache.org/jira/browse/MESOS-815
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> It seems that now that the slave uses async, this was sufficient to expose the lack of thread-safety in process::ID::generate. The ExamplesTest.TestFramework was crashing on a flaky basis for this reason.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 9952dd1505bcfc2f99e4349196e69fc8328a827c
>
> Diff: https://reviews.apache.org/r/15628/diff/
>
>
> Testing
> -------
>
> make check with many iterations of ExamplesTest.TestFramework, which previously was crashing on a flaky basis.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 15628: Fixed the thread-safety of process::ID::generate.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15628/#review29020
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Nov. 17, 2013, 12:37 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15628/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2013, 12:37 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
>
>
> Bugs: MESOS-815
> https://issues.apache.org/jira/browse/MESOS-815
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> It seems that now that the slave uses async, this was sufficient to expose the lack of thread-safety in process::ID::generate. The ExamplesTest.TestFramework was crashing on a flaky basis for this reason.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/process.cpp 9952dd1505bcfc2f99e4349196e69fc8328a827c
>
> Diff: https://reviews.apache.org/r/15628/diff/
>
>
> Testing
> -------
>
> make check with many iterations of ExamplesTest.TestFramework, which previously was crashing on a flaky basis.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 15628: Fixed the thread-safety of process::ID::generate.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15628/
-----------------------------------------------------------
(Updated Nov. 17, 2013, 12:37 a.m.)
Review request for mesos, Benjamin Hindman, Jie Yu, and Vinod Kone.
Changes
-------
Adding bug already filed by Jie!
Bugs: MESOS-815
https://issues.apache.org/jira/browse/MESOS-815
Repository: mesos-git
Description
-------
It seems that now that the slave uses async, this was sufficient to expose the lack of thread-safety in process::ID::generate. The ExamplesTest.TestFramework was crashing on a flaky basis for this reason.
Diffs
-----
3rdparty/libprocess/src/process.cpp 9952dd1505bcfc2f99e4349196e69fc8328a827c
Diff: https://reviews.apache.org/r/15628/diff/
Testing
-------
make check with many iterations of ExamplesTest.TestFramework, which previously was crashing on a flaky basis.
Thanks,
Ben Mahler