You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/15 16:40:57 UTC

[GitHub] [airflow] sarahamilton opened a new issue #13702: Google Marketing Platform Display and Video 360 SDF Operators Fail

sarahamilton opened a new issue #13702:
URL: https://github.com/apache/airflow/issues/13702


   <!--
   
   Welcome to Apache Airflow!  For a smooth issue process, try to answer the following questions.
   Don't worry if they're not all applicable; just try to include what you can :-)
   
   If you need to include code snippets or logs, please put them in fenced code
   blocks.  If they're super-long, please use the details tag like
   <details><summary>super-long log</summary> lots of stuff </details>
   
   Please delete these comment blocks before submitting the issue.
   
   -->
   
   <!--
   
   IMPORTANT!!!
   
   PLEASE CHECK "SIMILAR TO X EXISTING ISSUES" OPTION IF VISIBLE
   NEXT TO "SUBMIT NEW ISSUE" BUTTON!!!
   
   PLEASE CHECK IF THIS ISSUE HAS BEEN REPORTED PREVIOUSLY USING SEARCH!!!
   
   Please complete the next sections or the issue will be closed.
   These questions are the first thing we need to know to understand the context.
   
   -->
   
   **Apache Airflow version**: 1.10.12
   
   
   **Kubernetes version (if you are using kubernetes)** (use `kubectl version`):
   
   **Environment**: Google Cloud Composer 1.13.3
   
   - **Cloud provider or hardware configuration**: Google Cloud Composer
   
   **What happened**: All Google Marketing Platform Display and Video 360 SDF operations fail (other than creating the SDF). The "GoogleDisplayVideo360GetSDFDownloadOperationSensor" fails every time it runs in any DAG I have tested with the error 'Resource' object has no attribute 'operation'. 
   
   <!-- (please include exact error messages if you can) -->
   
   **What you expected to happen**: Given a valid SDF operation object that has been created, the operator should check if that object is ready to download. Then, the GoogleDisplayVideo360SDFtoGCSOperator should download the operation. However, the underlying hook that is being used is trying to reference an "operation" instead of "operations," per the SDF API specifications (see [here](https://developers.google.com/display-video/api/reference/rest/v1/sdfdownloadtasks.operations/get)). Thus, the requests always fail (as there is no "operation" attribute of the API).
   
   <!-- What do you think went wrong? -->
   
   **How to reproduce it**:
   <!---
   
   To reproduce, try to create a valid DAG that creates a new SDF file and then downloads it. I have tested with my own DAGs which are based on the example DAG provided in that code. I believe that if you run the SDF portion of the [Display and Video example DAG](https://github.com/apache/airflow/blob/master/airflow/providers/google/marketing_platform/example_dags/example_display_video.py) in the docs then the issue will occur, regardless of environment.
   
   ## Install minikube/kind
   
   - Minikube https://minikube.sigs.k8s.io/docs/start/
   - Kind https://kind.sigs.k8s.io/docs/user/quick-start/
   
   If this is a UI bug, please provide a screenshot of the bug or a link to a youtube video of the bug in action
   
   You can include images using the .md style of
   ![alt text](http://url/to/img.png)
   
   To record a screencast, mac users can use QuickTime and then create an unlisted youtube video with the resulting .mov file.
   
   --->
   
   
   **Anything else we need to know**: The patch is very simple -- I have already tested by patching my code locally and confirming that the patch fixes the problem. I will submit a pull request shortly.
   
   <!--
   
   How often does this problem occur? Once? Every time etc?
   
   Any relevant logs to include? Put them here in side a detail tag:
   <details><summary>x.log</summary> lots of stuff </details>
   
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #13702: Google Marketing Platform Display and Video 360 SDF Operators Fail

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #13702:
URL: https://github.com/apache/airflow/issues/13702#issuecomment-761049983


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal closed issue #13702: Google Marketing Platform Display and Video 360 SDF Operators Fail

Posted by GitBox <gi...@apache.org>.
eladkal closed issue #13702:
URL: https://github.com/apache/airflow/issues/13702


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] eladkal commented on issue #13702: Google Marketing Platform Display and Video 360 SDF Operators Fail

Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #13702:
URL: https://github.com/apache/airflow/issues/13702#issuecomment-813097489


   Fixed in https://github.com/apache/airflow/pull/13703


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org