You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2018/06/01 04:15:03 UTC

[1/3] impala git commit: [DOCS] Update composite or nested types in UDF

Repository: impala
Updated Branches:
  refs/heads/master fc0c5f58f -> 7a41f5874


[DOCS] Update composite or nested types in UDF

Change-Id: Ieda055f22e3d1e3507aacc8ba1e86e56d6f2e142
Reviewed-on: http://gerrit.cloudera.org:8080/10509
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/9cf8f198
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/9cf8f198
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/9cf8f198

Branch: refs/heads/master
Commit: 9cf8f19897be3b7ada6f84a3e3339ae7757accfa
Parents: fc0c5f5
Author: Alex Rodoni <ar...@cloudera.com>
Authored: Thu May 24 16:02:41 2018 -0700
Committer: Impala Public Jenkins <im...@cloudera.com>
Committed: Thu May 31 23:51:37 2018 +0000

----------------------------------------------------------------------
 docs/topics/impala_udf.xml | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/impala/blob/9cf8f198/docs/topics/impala_udf.xml
----------------------------------------------------------------------
diff --git a/docs/topics/impala_udf.xml b/docs/topics/impala_udf.xml
index 2481d63..1359594 100644
--- a/docs/topics/impala_udf.xml
+++ b/docs/topics/impala_udf.xml
@@ -609,9 +609,10 @@ IntVal AddUdf(FunctionContext* context, const IntVal&amp; arg1, const IntVal&amp
 
           <li>
             <p>
-              Because Impala currently does not support composite or nested types, Impala cannot process UDFs that
-              accept such types as arguments or return them as result values. This limitation applies both to
-              Impala UDFs written in C++ and Java-based Hive UDFs.
+              Impala cannot process UDFs that accept composite or nested types
+              as arguments or return them as result values. This limitation
+              applies both to Impala UDFs written in C++ and Java-based Hive
+              UDFs.
             </p>
           </li>
 


[2/3] impala git commit: IMPALA-7104: test_bloom_wait_time failing with timeout on asan

Posted by ta...@apache.org.
IMPALA-7104: test_bloom_wait_time failing with timeout on asan

test_bloom_wait_time checks that its query runs in less than a certain
amount of time, to ensure we aren't waiting on bloom filters that will
never arrive.

The test sometimes goes slightly over the timeout and fails on ASAN.
This patch uses a specific_build_type_timeout to extend the allowed
timeout for ASAN.

It also fixes a bug in a similar test where we were comparing a
duration in seconds to a timeout in milliseconds, and renames some
variables to make it clearer why this was a bug.

Change-Id: I0271eb83e65b3b5f17e32f6501032f0d12dde38e
Reviewed-on: http://gerrit.cloudera.org:8080/10565
Reviewed-by: Michael Brown <mi...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/7bd2f723
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/7bd2f723
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/7bd2f723

Branch: refs/heads/master
Commit: 7bd2f723a935e4b1715f0da0769471a2bb8f923b
Parents: 9cf8f19
Author: Thomas Tauber-Marshall <tm...@cloudera.com>
Authored: Thu May 31 15:13:42 2018 -0700
Committer: Impala Public Jenkins <im...@cloudera.com>
Committed: Fri Jun 1 02:03:40 2018 +0000

----------------------------------------------------------------------
 tests/query_test/test_runtime_filters.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/impala/blob/7bd2f723/tests/query_test/test_runtime_filters.py
----------------------------------------------------------------------
diff --git a/tests/query_test/test_runtime_filters.py b/tests/query_test/test_runtime_filters.py
index 38fd7a5..547a1ee 100644
--- a/tests/query_test/test_runtime_filters.py
+++ b/tests/query_test/test_runtime_filters.py
@@ -54,8 +54,8 @@ class TestRuntimeFilters(ImpalaTestSuite):
     mode"""
     now = time.time()
     self.run_test_case('QueryTest/runtime_filters_wait', vector)
-    duration = time.time() - now
-    assert duration < WAIT_TIME_MS, \
+    duration_s = time.time() - now
+    assert duration_s < (WAIT_TIME_MS / 1000), \
         "Query took too long (%ss, possibly waiting for missing filters?)" % str(duration)
 
   def test_file_filtering(self, vector):
@@ -91,8 +91,8 @@ class TestBloomFilters(ImpalaTestSuite):
     mode"""
     now = time.time()
     self.run_test_case('QueryTest/bloom_filters_wait', vector)
-    duration = time.time() - now
-    assert duration < 60, \
+    duration_s = time.time() - now
+    assert duration_s < (WAIT_TIME_MS / 1000), \
         "Query took too long (%ss, possibly waiting for missing filters?)" % str(duration)
 
 


[3/3] impala git commit: IMPALA-7099: xfail test on affected filesystems

Posted by ta...@apache.org.
IMPALA-7099: xfail test on affected filesystems

As a stopgap, let's xfail the test on filesystems where this
is known to be broken.

Testing:
Tested that the test succeeded and xfailed without and with an fs
prefix, i.e.:

  impala-py.test tests/metadata/test_partition_metadata.py -k unsupport
  FILESYSTEM_PREFIX="s3a://" impala-py.test tests/metadata/test_partition_metadata.py -k unsupport

Change-Id: Ie5dd744d48f099b3b12607ad91454e71733f1c6a
Reviewed-on: http://gerrit.cloudera.org:8080/10566
Reviewed-by: Dan Hecht <dh...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/7a41f587
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/7a41f587
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/7a41f587

Branch: refs/heads/master
Commit: 7a41f587473603e31911fc4b58d7ff829ed11952
Parents: 7bd2f72
Author: Tim Armstrong <ta...@cloudera.com>
Authored: Thu May 31 17:33:35 2018 -0700
Committer: Impala Public Jenkins <im...@cloudera.com>
Committed: Fri Jun 1 03:57:30 2018 +0000

----------------------------------------------------------------------
 tests/metadata/test_partition_metadata.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/impala/blob/7a41f587/tests/metadata/test_partition_metadata.py
----------------------------------------------------------------------
diff --git a/tests/metadata/test_partition_metadata.py b/tests/metadata/test_partition_metadata.py
index e3cc2c1..1995920 100644
--- a/tests/metadata/test_partition_metadata.py
+++ b/tests/metadata/test_partition_metadata.py
@@ -15,11 +15,12 @@
 # specific language governing permissions and limitations
 # under the License.
 
+import pytest
 from tests.common.impala_test_suite import ImpalaTestSuite
 from tests.common.skip import SkipIfS3, SkipIfADLS, SkipIfIsilon, SkipIfLocal
 from tests.common.test_dimensions import (create_single_exec_option_dimension,
     create_uncompressed_text_dimension)
-from tests.util.filesystem_utils import get_fs_path, WAREHOUSE
+from tests.util.filesystem_utils import get_fs_path, WAREHOUSE, FILESYSTEM_PREFIX
 
 # Map from the test dimension file_format string to the SQL "STORED AS"
 # argument.
@@ -163,6 +164,8 @@ class TestPartitionMetadataUncompressedTextOnly(ImpalaTestSuite):
   def test_unsupported_text_compression(self, vector, unique_database):
     """Test querying tables with a mix of supported and unsupported compression codecs.
     Should be able to query partitions with supported codecs."""
+    if FILESYSTEM_PREFIX:
+      pytest.xfail("IMPALA-7099: this test's filesystem prefix handling is broken")
     TBL_NAME = "multi_text_compression"
     FQ_TBL_NAME = unique_database + "." + TBL_NAME
     TBL_LOCATION = '%s/%s.db/%s' % (WAREHOUSE, unique_database, TBL_NAME)