You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "lostluck (via GitHub)" <gi...@apache.org> on 2023/06/29 08:30:47 UTC
[GitHub] [beam] lostluck opened a new pull request, #27299: [#27207] Update Go quickstart.
lostluck opened a new pull request, #27299:
URL: https://github.com/apache/beam/pull/27299
Update the Go quickstart to reduce the environmental demand on a user. This PR fixes walls users might encounter from following the instructions.
* Move from installing the wordcount to simply executing it. Installing runs the risk the user doesn't have the go/bin directory on their PATH (or OS equivalent). We shouldn't make this assumption.
* Remove unnecessary steps leading to execution.
* Reference the Beam Go Starter project in next steps.
The Quickstart really should jump from that to building a pipeline from scratch with Go and explain a little bit more about what's going on, as Quickstarts are often a first landing page for new users. But that's a task for a later PR.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #27299: [#27207] Update Go quickstart.
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #27299:
URL: https://github.com/apache/beam/pull/27299#issuecomment-1612634206
R: @aromanenko-dev
I hope this resolves the issues you ran into! The quickstart definitely needs some work and actually show building a pipeline from scratch, but I've filed https://github.com/apache/beam/issues/27300 to track that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #27299: [#27207] Update Go quickstart.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27299:
URL: https://github.com/apache/beam/pull/27299#issuecomment-1612636158
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev merged pull request #27299: [#27207] Update Go quickstart.
Posted by "aromanenko-dev (via GitHub)" <gi...@apache.org>.
aromanenko-dev merged PR #27299:
URL: https://github.com/apache/beam/pull/27299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aromanenko-dev commented on a diff in pull request #27299: [#27207] Update Go quickstart.
Posted by "aromanenko-dev (via GitHub)" <gi...@apache.org>.
aromanenko-dev commented on code in PR #27299:
URL: https://github.com/apache/beam/pull/27299#discussion_r1246882684
##########
website/www/site/content/en/get-started/quickstart-go.md:
##########
@@ -51,22 +43,18 @@ required arguments described in the examples.
For example, to run `wordcount`, run:
{{< runner direct >}}
-$ go install github.com/apache/beam/sdks/v2/go/examples/wordcount
-$ wordcount --input <PATH_TO_INPUT_FILE> --output counts
+$ go run github.com/apache/beam/sdks/v2/go/examples/wordcount@latest --input "gs://apache-beam-samples/shakespeare/kinglear.txt" --output counts
+$ less counts
{{< /runner >}}
{{< runner dataflow >}}
-$ go install github.com/apache/beam/sdks/v2/go/examples/wordcount
-# As part of the initial setup, for non linux users - install package unix before run
-$ go get -u golang.org/x/sys/unix
-$ wordcount --input gs://dataflow-samples/shakespeare/kinglear.txt \
+$ go run github.com/apache/beam/sdks/v2/go/examples/wordcount@latest --input gs://dataflow-samples/shakespeare/kinglear.txt \
Review Comment:
Should we use the same path `gs://apache-beam-samples/shakespeare/kinglear.txt` as above for consistency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org