You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/11/12 12:57:55 UTC

[GitHub] [hudi] nsivabalan opened a new pull request #3983: [HUDI-2753] Ensure list based rollback strategy is used for restore

nsivabalan opened a new pull request #3983:
URL: https://github.com/apache/hudi/pull/3983


   ## What is the purpose of the pull request
   
   Restore internally does rollback of N commits in reverse chronological order. Since these are completed instants, we have to use list based rollback strategy irrespective of what the writeconfig says for rollback strategy. Fixed the rollback planning phase to take an explicit argument on this regard and honor the same. 
   
   ## Brief change log
   
   - Fixed rollback scheduling/planning to take an explicit argument for the rollback strategy to use instead of relying on writeConfig values. 
   
   ## Verify this pull request
   
   This pull request is already covered by existing tests.
   
   - Flipped to rollback based marker strategy in one of the tests which involves restore. Without the fix, the test fails and now it succeeds. 
   TestHoodieClientOnCopyOnWriteStorage#testUpserts
   
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3983: [HUDI-2753] Ensure list based rollback strategy is used for restore

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3983:
URL: https://github.com/apache/hudi/pull/3983#issuecomment-967101972


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "97325c1a81277387f89c5f64f84137d2cd1e8e37",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "97325c1a81277387f89c5f64f84137d2cd1e8e37",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 97325c1a81277387f89c5f64f84137d2cd1e8e37 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3983: [HUDI-2753] Ensure list based rollback strategy is used for restore

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3983:
URL: https://github.com/apache/hudi/pull/3983#issuecomment-967135859


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "97325c1a81277387f89c5f64f84137d2cd1e8e37",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3334",
       "triggerID" : "97325c1a81277387f89c5f64f84137d2cd1e8e37",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 97325c1a81277387f89c5f64f84137d2cd1e8e37 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3334) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3983: [HUDI-2753] Ensure list based rollback strategy is used for restore

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3983:
URL: https://github.com/apache/hudi/pull/3983#issuecomment-967101972


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "97325c1a81277387f89c5f64f84137d2cd1e8e37",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "97325c1a81277387f89c5f64f84137d2cd1e8e37",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 97325c1a81277387f89c5f64f84137d2cd1e8e37 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #3983: [HUDI-2753] Ensure list based rollback strategy is used for restore

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3983:
URL: https://github.com/apache/hudi/pull/3983#issuecomment-967103574


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "97325c1a81277387f89c5f64f84137d2cd1e8e37",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3334",
       "triggerID" : "97325c1a81277387f89c5f64f84137d2cd1e8e37",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 97325c1a81277387f89c5f64f84137d2cd1e8e37 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3334) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #3983: [HUDI-2753] Ensure list based rollback strategy is used for restore

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #3983:
URL: https://github.com/apache/hudi/pull/3983#issuecomment-967103574


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "97325c1a81277387f89c5f64f84137d2cd1e8e37",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3334",
       "triggerID" : "97325c1a81277387f89c5f64f84137d2cd1e8e37",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 97325c1a81277387f89c5f64f84137d2cd1e8e37 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=3334) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] codope merged pull request #3983: [HUDI-2753] Ensure list based rollback strategy is used for restore

Posted by GitBox <gi...@apache.org>.
codope merged pull request #3983:
URL: https://github.com/apache/hudi/pull/3983


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org