[jira] [Commented] (ARTEMIS-1986) PagingTest#testDeletePhysicalPages will fail if a record about deleting a page is not saved in journal

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARTEMIS-1986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16552913#comment-16552913 ] 

ASF GitHub Bot commented on ARTEMIS-1986:
-----------------------------------------

GitHub user JiriOndrusek opened a pull request:

    https://github.com/apache/activemq-artemis/pull/2188

    [ARTEMIS-1986] PagingTest#testDeletePhysicalPages will fail if a record about deleting a page is not saved in journal

    Issue: https://issues.apache.org/jira/browse/ARTEMIS-1986
    
    Change contains only test which is introduced as a part of fix on downstream issue, because issue is not happening on master.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/JiriOndrusek/activemq-artemis ARTEMIS-1986-test

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/2188.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2188
    
----
commit 3743bc1e89858be8b86289e3c93075097b6789fd
Author: JiriOndrusek <jo...@...>
Date:   2018-07-23T12:17:24Z

    [ARTEMIS-1986] PagingTest#testDeletePhysicalPages will fail if a record about deleting a page is not saved in journal

----


> PagingTest#testDeletePhysicalPages will fail if a record about deleting a page is not saved in journal 
> -------------------------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-1986
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1986
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 1.5.5
>            Reporter: Jiri Ondrusek
>            Priority: Major
>
> *Apply:* byteman rule, which simulates case of filesystem error (or restart in one specific moment) - so record of page deletion is not sored into journal
> {quote}RULE skip delete page complete record for page 120
> CLASS org.apache.activemq.artemis.core.paging.cursor.impl.PageSubscriptionImpl
> METHOD onDeletePage(Page)
> AT ENTRY
> IF $1.getPageId() == 120
> DO
>  RETURN
> ENDRULE
> {quote}
> *Scenario*:
>  # send 1000 messages
>  # restart server
>  # receive 1000 messages
>  # stop server
>  # delete Paging directory
>  # start server
>  # send 1000 messages
>  # restart server
>  # receive 1000 messages
> *Expected result*: All messages are delivered.
> *Actual result*: Sometimes some messages are lost.
> *Customer impact*: The issue is related to paging. When customer restart server during receiving paged messages, some messages may be lost after the restart.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)