You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/10/28 14:56:27 UTC
[GitHub] [couchdb-erlfdb] kocolosk opened a new pull request #27: Add a dev container configuration for VS Code
kocolosk opened a new pull request #27:
URL: https://github.com/apache/couchdb-erlfdb/pull/27
This creates a development environment with a FoundationDB server and an erlfdb client in two containers, sharing a network through Docker Compose.
It uses the FDB image published to Docker Hub for the FDB container, and downloads the FDB client packages from foundationdb.org to provide the development headers and libraries. Once the Docker Compose setup is running, VS Code executes the `create_cluster_file.bash` script to write down a cluster file containing the IP address in the compose network where the FDB service can be found.
I installed the Python bindings for FDB in this container as well. This can simplify the process to run the bindings tester since we won't actually have to build FoundationDB itself. I could foresee a bit more work on this front to make it possible to run those tests out of the box, but it would also require some refactoring on the FoundationDB side to extract those tests and make it possible to add new testers dynamically. Or we just copypasta the test framework into this repo and keep it in sync manually -- it doesn't change very often.
## Requests for Reviewer
I did make one change to erlfdb itself that's worth discussing. I made it so that the test suite will try to run `configure new single ssd` even when a user supplied a custom `test_cluster_file` in the erlfdb application environment. Previously we only ran that command when the test suite was starting its own server. This is a safe operation when a cluster is already properly configured, but if a cluster is in a misconfigured state the command could cause the cluster to drop whatever data it might have been storing previously.
## Testing Recommendation
Open the repo in VS Code and it should offer to reopen inside the container. Open a terminal in the editor once the container is build and run `make`; erlfdb should build and run unit tests successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-erlfdb] kocolosk commented on pull request #27: Add a dev container configuration for VS Code
Posted by GitBox <gi...@apache.org>.
kocolosk commented on pull request #27:
URL: https://github.com/apache/couchdb-erlfdb/pull/27#issuecomment-962489377
Now that I've tweaked this so it doesn't modify any project source code I'd argue it's OK to merge without a review. I've been using it quite successfully for the past couple of weeks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb-erlfdb] kocolosk merged pull request #27: Add a dev container configuration for VS Code
Posted by GitBox <gi...@apache.org>.
kocolosk merged pull request #27:
URL: https://github.com/apache/couchdb-erlfdb/pull/27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org