[jira] Resolved: (HBASE-3405) Allow HBaseRpcMetrics to register custom interface methods

["Gary Helmling (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-3405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary Helmling resolved HBASE-3405.
----------------------------------

       Resolution: Fixed
    Fix Version/s: 0.90.0
         Assignee: Gary Helmling

Committed to 0.90 branch and trunk.

> Allow HBaseRpcMetrics to register custom interface methods
> ----------------------------------------------------------
>
>                 Key: HBASE-3405
>                 URL: https://issues.apache.org/jira/browse/HBASE-3405
>             Project: HBase
>          Issue Type: Improvement
>          Components: ipc
>            Reporter: Gary Helmling
>            Assignee: Gary Helmling
>            Priority: Minor
>             Fix For: 0.90.0
>
>         Attachments: HBASE-3405_2_0.90.patch, HBASE-3405_trunk.patch
>
>
> Opened from comments on HBASE-2997.  James Kennedy notes:
> {quote}
> HBaseRpcMetrics is now logging a WARN message every time it encounters an unregistered RPC method.
> In my case I now get huge log files filled with these warnings because the hbase-trx transactional extension of HBase uses a subclass of HRegionServer that adds new interface methods.
> It's easy enough to tell log4j to ignore HBaseRpcMetrics output.
> However, it would be nice if the Server/HRegionServer HBaseRpcMetrics mechanism was more extensible so I could pass down new interfaces or grab the HBaseRpcMetrics object to add interfaces from up top...
> {quote}
> {{HBaseRpcMetrics}} already has a public method {{createMetrics(Class)}} to register method counters.  We just need a way to expose the metrics class to allow the region server subclass to call it -- add a {{getMetrics()}} method to {{RpcServer}} and {{HBaseServer}}.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.