You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Devaraj Das (JIRA)" <ji...@apache.org> on 2012/07/18 00:14:34 UTC
[jira] [Created] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Devaraj Das created HBASE-6414:
----------------------------------
Summary: Remove the WritableRpcEngine & associated Invocation classes
Key: HBASE-6414
URL: https://issues.apache.org/jira/browse/HBASE-6414
Project: HBase
Issue Type: Improvement
Affects Versions: 0.96.0
Reporter: Devaraj Das
Assignee: Devaraj Das
Fix For: 0.96.0
Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435428#comment-13435428 ]
Hadoop QA commented on HBASE-6414:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12541096/6414-5.patch.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 18 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.wal.TestHLog
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2591//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2591//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2591//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2591//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2591//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2591//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2591//console
This message is automatically generated.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-6.txt, 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432094#comment-13432094 ]
Hadoop QA commented on HBASE-6414:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12540093/6414-3.patch.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 18 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestHMasterRPCException
org.apache.hadoop.hbase.client.TestFromClientSide
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2546//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2546//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2546//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2546//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2546//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2546//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2546//console
This message is automatically generated.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432249#comment-13432249 ]
Zhihong Ted Yu edited comment on HBASE-6414 at 8/9/12 10:40 PM:
----------------------------------------------------------------
Using the previous patch, I ran TestHMasterRPCException#testRPCException 3 times.
I saw the following twice:
{code}
Failed tests: testRPCException(org.apache.hadoop.hbase.master.TestHMasterRPCException): Call to lm-sjn-0071.y.com/10.246.12.139:55121 failed on socket timeout exception: java.net.SocketTimeoutException: 100 millis timeout while waiting for channel to be ready for read. ch : java.nio.channels.SocketChannel[connected ...
{code}
Can we not introduce loop but instead rely on some additional sleep ?
Thanks
was (Author: zhihyu@ebaysf.com):
Using the previous patch, I ran TestHMasterRPCException#testRPCException 3 times.
I saw the following twice:
{code}
Failed tests: testRPCException(org.apache.hadoop.hbase.master.TestHMasterRPCException): Call to lm-sjn-00713032.corp.ebay.com/10.246.12.139:55121 failed on socket timeout exception: java.net.SocketTimeoutException: 100 millis timeout while waiting for channel to be ready for read. ch : java.nio.channels.SocketChannel[connected ...
{code}
Can we not introduce loop but instead rely on some additional sleep ?
Thanks
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437678#comment-13437678 ]
Devaraj Das commented on HBASE-6414:
------------------------------------
Thanks Stack. BTW the files hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java and hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestPBOnWritableRpc.java should be deleted from svn (currently they are 0 length files).
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-6.patch.txt, 6414-6.patch.txt, 6414-6.txt, 6414-initial.patch.txt, 6414-initial.patch.txt, 6414-v7.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428980#comment-13428980 ]
Zhihong Ted Yu commented on HBASE-6414:
---------------------------------------
{code}
+ public AuthenticationTokenSecretManager createSecretManager(){
{code}
I only find one reference to the above method. I guess it doesn't have to be public.
{code}
+ Class<? extends Message> rpcArgClassname = null;
{code}
The above variable represents Class, not Class name.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HBASE-6414:
-------------------------------
Attachment: 6414-initial.patch.txt
Wanted to run this patch through hadoopqa
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438904#comment-13438904 ]
Devaraj Das commented on HBASE-6414:
------------------------------------
bq. I'm fixing it in HBASE-6364. I didn't check if there were other stuff like this.
Thanks, Nicolas. Will fix any remaining ones in HBASE-6614.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-6.patch.txt, 6414-6.patch.txt, 6414-6.txt, 6414-initial.patch.txt, 6414-initial.patch.txt, 6414-v7.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435393#comment-13435393 ]
Zhihong Ted Yu commented on HBASE-6414:
---------------------------------------
I ran the following tests locally and they passed:
{code}
2002 mts -Dtest=TestScannerTimeout#test3686a
2004 mts -Dtest=TestReplication#queueFailover
{code}
No repeatable test failure.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-6.txt, 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437601#comment-13437601 ]
Hudson commented on HBASE-6414:
-------------------------------
Integrated in HBase-TRUNK #3241 (See [https://builds.apache.org/job/HBase-TRUNK/3241/])
HBASE-6414 Remove the WritableRpcEngine & associated Invocation classes (Revision 1374860)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ClientCache.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ProtobufRpcEngine.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredRPCHandler.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredRPCHandlerImpl.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RPCProtos.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/trunk/hbase-server/src/main/protobuf/RPC.proto
* /hbase/trunk/hbase-server/src/main/resources/hbase-default.xml
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestPBOnWritableRpc.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/protobuf/generated/TestDelayedRpcProtos.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestHMasterRPCException.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPriorityRpc.java
* /hbase/trunk/hbase-server/src/test/protobuf/test_delayed_rpc.proto
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-6.patch.txt, 6414-6.patch.txt, 6414-6.txt, 6414-initial.patch.txt, 6414-initial.patch.txt, 6414-v7.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435335#comment-13435335 ]
Devaraj Das commented on HBASE-6414:
------------------------------------
On my machine, tests passed.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-6.txt, 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435510#comment-13435510 ]
Zhihong Ted Yu commented on HBASE-6414:
---------------------------------------
I ran TestHLog and it passed locally:
{code}
Running org.apache.hadoop.hbase.regionserver.wal.TestHLog
Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 70.98 sec
{code}
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-6.txt, 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432853#comment-13432853 ]
stack commented on HBASE-6414:
------------------------------
I put comments up on rb DD.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-5.patch.txt, 6414-6.txt, 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "nkeywal (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438573#comment-13438573 ]
nkeywal commented on HBASE-6414:
--------------------------------
For this
{noformat}
/**
- * Construct an IPC client whose values are of the given {@link Writable}
+ * Construct an IPC client whose values are of the {@link Message}
* class.
* @param valueClass value class
* @param conf configuration
* @param factory socket factory
*/
- public HBaseClient(Class<? extends Writable> valueClass, Configuration conf,
- SocketFactory factory) {
- this.valueClass = valueClass;
+ public HBaseClient(Configuration conf, SocketFactory factory) {
{noformat}
The javadoc was not updated, nor in ipc/ClientCache.java.
I'm fixing it in HBASE-6364. I didn't check if there were other stuff like this.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-6.patch.txt, 6414-6.patch.txt, 6414-6.txt, 6414-initial.patch.txt, 6414-initial.patch.txt, 6414-v7.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HBASE-6414:
-------------------------------
Attachment: 6414-4.patch.txt
Retrying hadoopqa ping.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HBASE-6414:
-------------------------------
Attachment: 6414-1.patch.txt
Passing the new patch through hudson.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437425#comment-13437425 ]
stack commented on HBASE-6414:
------------------------------
v7 over RB is good to go. Attach here DD so we can run through hadooopqa and commit. Good stuff.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-6.patch.txt, 6414-6.txt, 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu updated HBASE-6414:
----------------------------------
Attachment: 6414-6.txt
Patch v6 removes some whitespace from TestHMasterRPCException.java
An else keyword is removed due to the return statement in its if block.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-5.patch.txt, 6414-6.txt, 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437608#comment-13437608 ]
Hudson commented on HBASE-6414:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #137 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/137/])
HBASE-6414 Remove the WritableRpcEngine & associated Invocation classes (Revision 1374860)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ClientCache.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseRPC.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ProtobufRpcEngine.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredRPCHandler.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredRPCHandlerImpl.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/protobuf/generated/RPCProtos.java
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
* /hbase/trunk/hbase-server/src/main/protobuf/RPC.proto
* /hbase/trunk/hbase-server/src/main/resources/hbase-default.xml
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestPBOnWritableRpc.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/protobuf/generated/TestDelayedRpcProtos.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestHMasterRPCException.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPriorityRpc.java
* /hbase/trunk/hbase-server/src/test/protobuf/test_delayed_rpc.proto
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-6.patch.txt, 6414-6.patch.txt, 6414-6.txt, 6414-initial.patch.txt, 6414-initial.patch.txt, 6414-v7.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6414:
-------------------------
Attachment: 6414-v7.txt
v6 w/ a DEBUG log removed (we were logging every call).. I changed it to trace level.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-6.patch.txt, 6414-6.patch.txt, 6414-6.txt, 6414-initial.patch.txt, 6414-initial.patch.txt, 6414-v7.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437927#comment-13437927 ]
stack commented on HBASE-6414:
------------------------------
Thanks DD. I just removed them.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-6.patch.txt, 6414-6.patch.txt, 6414-6.txt, 6414-initial.patch.txt, 6414-initial.patch.txt, 6414-v7.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437991#comment-13437991 ]
Hudson commented on HBASE-6414:
-------------------------------
Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #138 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/138/])
HBASE-6414 Remove the WritableRpcEngine & associated Invocation classes; REMOVE EMPTY FILES (Revision 1375051)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestPBOnWritableRpc.java
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-6.patch.txt, 6414-6.patch.txt, 6414-6.txt, 6414-initial.patch.txt, 6414-initial.patch.txt, 6414-v7.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432275#comment-13432275 ]
Devaraj Das commented on HBASE-6414:
------------------------------------
bq. Can we not introduce loop but instead rely on some additional sleep ?
I actually like [looping with a small sleep] better than a [big sleep]. This makes the tests responsive on some machines, and yet be able to tolerate slower machines.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433485#comment-13433485 ]
Devaraj Das commented on HBASE-6414:
------------------------------------
bq. I put comments up on rb DD.
Ack. I am going through them. Good questions.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-5.patch.txt, 6414-6.txt, 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432096#comment-13432096 ]
Zhihong Ted Yu commented on HBASE-6414:
---------------------------------------
@Devaraj:
I think the following test failure is related to the patch:
https://builds.apache.org/job/PreCommit-HBASE-Build/2546//testReport/org.apache.hadoop.hbase.master/TestHMasterRPCException/testRPCException/
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HBASE-6414:
-------------------------------
Attachment: 6414-6.patch.txt
Ted had uploaded the last patch from RB (thanks, Ted!) but hadoopqa didn't pick it up.. Re-uploading the same patch.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-6.patch.txt, 6414-6.patch.txt, 6414-6.txt, 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HBASE-6414:
-------------------------------
Issue Type: Sub-task (was: Improvement)
Parent: HBASE-5305
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-6.patch.txt, 6414-6.patch.txt, 6414-6.txt, 6414-initial.patch.txt, 6414-initial.patch.txt, 6414-v7.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13431493#comment-13431493 ]
Devaraj Das commented on HBASE-6414:
------------------------------------
https://reviews.apache.org/r/6491 has the patch up for review.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu updated HBASE-6414:
----------------------------------
Attachment: 6414-5.patch.txt
Attaching latest patch again.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-6.txt, 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432356#comment-13432356 ]
Zhihong Ted Yu commented on HBASE-6414:
---------------------------------------
@Devaraj:
I am fine with your latest patch if 'java.net.SocketTimeoutException' is checked against ex.getMessage() in the loop.
If exception other than SocketTimeoutException and ServerNotRunningYetException is encountered, the test should be considered a failure.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu updated HBASE-6414:
----------------------------------
Attachment: 6414-5.patch.txt
Patch from rb.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-5.patch.txt, 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432351#comment-13432351 ]
Devaraj Das commented on HBASE-6414:
------------------------------------
@Zhihyu: My testcase patch has a loop, and sleeps for 1000 millis (which I meant to have as 100 millis actually) if the method doesn't throw the desired exception. Your testcase patch sleeps for a longer time interval before invoking the method on which the exception is expected to be thrown..
I am okay with either of the approaches as long as you have a loop and a smaller sleep interval :-)
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HBASE-6414:
-------------------------------
Attachment: 6414-4.patch.txt
The new patch from RB.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434942#comment-13434942 ]
Hadoop QA commented on HBASE-6414:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12541005/6414-5.patch.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 18 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2581//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2581//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2581//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2581//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2581//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2581//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2581//console
This message is automatically generated.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-6.txt, 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu updated HBASE-6414:
----------------------------------
Attachment: 6414-5.patch.txt
Latest patch from DD.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-6.txt, 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HBASE-6414:
-------------------------------
Attachment: 6414-initial.patch.txt
Initial patch. Builds. Will start testing it.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432249#comment-13432249 ]
Zhihong Ted Yu commented on HBASE-6414:
---------------------------------------
Using the previous patch, I ran TestHMasterRPCException#testRPCException 3 times.
I saw the following twice:
{code}
Failed tests: testRPCException(org.apache.hadoop.hbase.master.TestHMasterRPCException): Call to lm-sjn-00713032.corp.ebay.com/10.246.12.139:55121 failed on socket timeout exception: java.net.SocketTimeoutException: 100 millis timeout while waiting for channel to be ready for read. ch : java.nio.channels.SocketChannel[connected ...
{code}
Can we not introduce loop but instead rely on some additional sleep ?
Thanks
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428633#comment-13428633 ]
Devaraj Das commented on HBASE-6414:
------------------------------------
bq. TestPBOnWritableRpc can be removed once conversion to PB is complete, right ?
Right. I should remove the relevant code.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437565#comment-13437565 ]
Hadoop QA commented on HBASE-6414:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12541532/6414-6.patch.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 18 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 6 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.master.TestAssignmentManager
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2622//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2622//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2622//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2622//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2622//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2622//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2622//console
This message is automatically generated.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-6.patch.txt, 6414-6.patch.txt, 6414-6.txt, 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432287#comment-13432287 ]
Zhihong Ted Yu commented on HBASE-6414:
---------------------------------------
The difference between my suggestion and the latest patch is that Timeout exception is not ignored in my change - we know that the first exception we should receive is ServerNotRunningYetException :-)
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HBASE-6414:
-------------------------------
Status: Patch Available (was: Open)
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428957#comment-13428957 ]
Zhihong Ted Yu commented on HBASE-6414:
---------------------------------------
{code}
+ if (builder.mergeDelimitedFrom(in)) {
+ value = builder.build();
+ }
{code}
Should there be an else block for the above if ?
{code}
+ } catch (Exception e) {
+ // TODO Auto-generated catch block
+ e.printStackTrace();
{code}
Should something similar to closeException be introduced to save the caught exception ?
There're a few white spaces, visible if you put the patch on review board.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428579#comment-13428579 ]
Hadoop QA commented on HBASE-6414:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12539144/6414-initial.patch.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 9 new or modified tests.
+1 hadoop2.0. The patch compiles against the hadoop 2.0 profile.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).
-1 findbugs. The patch appears to introduce 10 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.ipc.TestPBOnWritableRpc
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2506//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2506//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2506//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2506//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2506//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2506//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2506//console
This message is automatically generated.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-6414:
-------------------------
Resolution: Fixed
Hadoop Flags: Incompatible change,Reviewed
Status: Resolved (was: Patch Available)
Committed v7. Good stuff DD.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-6.patch.txt, 6414-6.patch.txt, 6414-6.txt, 6414-initial.patch.txt, 6414-initial.patch.txt, 6414-v7.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432258#comment-13432258 ]
Zhihong Ted Yu commented on HBASE-6414:
---------------------------------------
With the following proposed change, I ran TestHMasterRPCException#testRPCException 9 times and it passed:
{code}
Index: hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestHMasterRPCException.java
===================================================================
--- hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestHMasterRPCException.java (revision 1371504)
+++ hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestHMasterRPCException.java (working copy)
@@ -23,18 +23,20 @@
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
+import java.io.IOException;
import java.net.InetSocketAddress;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.hbase.*;
import org.apache.hadoop.hbase.ipc.HBaseRPC;
import org.apache.hadoop.hbase.MasterMonitorProtocol;
-import org.apache.hadoop.hbase.protobuf.RequestConverter;
-import org.apache.hadoop.ipc.RemoteException;
-import org.apache.hadoop.hbase.ipc.ServerNotRunningYetException;
+import org.apache.hadoop.hbase.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.protobuf.generated.MasterProtos.IsMasterRunningRequest;
import org.junit.Test;
import org.junit.experimental.categories.Category;
+import com.google.protobuf.ServiceException;
+
@Category(MediumTests.class)
public class TestHMasterRPCException {
@@ -52,9 +54,12 @@
try {
MasterMonitorProtocol inf = (MasterMonitorProtocol) HBaseRPC.getProxy(
MasterMonitorProtocol.class, MasterMonitorProtocol.VERSION, isa, conf, 100);
+ Thread.sleep(500);
+ inf.isMasterRunning(null, IsMasterRunningRequest.getDefaultInstance());
fail();
- } catch (ServerNotRunningYetException ex) {
- assertTrue(ex.getMessage().startsWith(
+ } catch (ServiceException ex) {
+ IOException ie = ProtobufUtil.getRemoteException(ex);
+ assertTrue(ie.getMessage(), ie.getMessage().startsWith(
"org.apache.hadoop.hbase.ipc.ServerNotRunningYetException: Server is not running yet"));
} catch (Throwable t) {
fail("Unexpected throwable: " + t);
{code}
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Ted Yu updated HBASE-6414:
----------------------------------
Attachment: 6414-6.patch.txt
Patch from review board.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-6.patch.txt, 6414-6.txt, 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438001#comment-13438001 ]
Hudson commented on HBASE-6414:
-------------------------------
Integrated in HBase-TRUNK #3242 (See [https://builds.apache.org/job/HBase-TRUNK/3242/])
HBASE-6414 Remove the WritableRpcEngine & associated Invocation classes; REMOVE EMPTY FILES (Revision 1375051)
Result = FAILURE
stack :
Files :
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/WritableRpcEngine.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestPBOnWritableRpc.java
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-6.patch.txt, 6414-6.patch.txt, 6414-6.txt, 6414-initial.patch.txt, 6414-initial.patch.txt, 6414-v7.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435115#comment-13435115 ]
Zhihong Ted Yu commented on HBASE-6414:
---------------------------------------
>From https://builds.apache.org/job/PreCommit-HBASE-Build/2581/console, it is not clear which test hung.
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-6.txt, 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HBASE-6414:
-------------------------------
Attachment: 6414-3.patch.txt
Patch from RB. Attaching here to get it through hudson (the previous attempt failed).
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437686#comment-13437686 ]
Devaraj Das commented on HBASE-6414:
------------------------------------
I raised this to take care of issues like double deserialization & others we come across in RPC.. https://issues.apache.org/jira/browse/HBASE-6614
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-6.patch.txt, 6414-6.patch.txt, 6414-6.txt, 6414-initial.patch.txt, 6414-initial.patch.txt, 6414-v7.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine &
associated Invocation classes
Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428608#comment-13428608 ]
Zhihong Ted Yu commented on HBASE-6414:
---------------------------------------
TestPBOnWritableRpc can be removed once conversion to PB is complete, right ?
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
> Key: HBASE-6414
> URL: https://issues.apache.org/jira/browse/HBASE-6414
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 0.96.0
> Reporter: Devaraj Das
> Assignee: Devaraj Das
> Fix For: 0.96.0
>
> Attachments: 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed and all the protocols are rebased to use PB.
> Raising this jira in advance..
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira