You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "davsclaus (via GitHub)" <gi...@apache.org> on 2026/10/06 15:16:23 UTC
[PR] CAMEL-25380: camel-yaml-dsl - Do not log the compact notation warning for YAML inside a jar [camel]
davsclaus opened a new pull request, #27448:
URL: https://github.com/apache/camel/pull/27448
https://issues.apache.org/jira/browse/CAMEL-25380
Using `timer-source`, `extract-field-action` or `predicate-filter-action` logged this on every load and dev-mode reload:
```
WARN YAML DSL compact notation detected in: classpath:kamelets/timer-source.kamelet.yaml. ... Use Camel CLI to normalize: camel validate normalize <file>
```
That tells the user, or an AI agent reading the log, to fix a file inside a jar they can't change. With this change there's no warning when the resource is a `classpath:` resource that resolves into a jar.
The real fix for the shipped Kamelets is canonical YAML in camel-kamelets, which needs `camel validate normalize` to support Kamelet files first (CAMEL-25381). This change keeps older pinned Kamelet versions and third-party Kamelet jars quiet.
Test: `CompactNotationWarnTest.aFileInsideAJarIsNotWarnedAbout` fails without the change and passes with it. camel-yaml-dsl passes 459 of 459.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
https://claude.ai/code/session_01STT6whBgK1AqsSsUKrnE8m
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-25380: camel-yaml-dsl - Do not log the compact notation warning for the Kamelets of the Kamelet catalog [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #27448:
URL: https://github.com/apache/camel/pull/27448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-25380: camel-yaml-dsl - Do not log the compact notation warning for YAML inside a jar [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27448:
URL: https://github.com/apache/camel/pull/27448#issuecomment-6020136973
<!-- ci-tested-modules -->
:test_tube: **CI tested the following changed modules:**
- `dsl/camel-yaml-dsl/camel-yaml-dsl`
---
<details><summary>:microscope: Scalpel shadow comparison — Scalpel: 8 of 699 tested, 10 compile-only — current: 8 all tested</summary>
[Maveniverse Scalpel](https://github.com/maveniverse/scalpel) detected **8 affected modules** (current approach: 8).
**Skip-tests mode would test 8 modules** (1 direct + 8 downstream), **skip tests for 10** (generated code, meta-modules)
<details><summary>Modules Scalpel would test (8)</summary>
- `camel-jbang-mcp` ← downstream of org.apache.camel:camel-yaml-dsl
- `camel-jbang-plugin-mcp` ← downstream of org.apache.camel:camel-jbang-core
- `camel-jbang-plugin-route-parser` ← downstream of org.apache.camel:camel-jbang-core
- `camel-jbang-plugin-tui` ← downstream of org.apache.camel:camel-yaml-dsl-validator
- `camel-jbang-plugin-validate` ← downstream of org.apache.camel:camel-yaml-dsl-validator
- `camel-launcher-container` ← downstream of org.apache.camel:camel-launcher
- `camel-yaml-dsl-validator` ← downstream of org.apache.camel:camel-yaml-dsl
- `camel-yaml-dsl-validator-maven-plugin` ← downstream of org.apache.camel:camel-yaml-dsl-validator
</details>
<details><summary>Modules with tests skipped (10)</summary>
- `camel-jbang-core`
- `camel-jbang-it`
- `camel-jbang-main`
- `camel-jbang-plugin-edit`
- `camel-jbang-plugin-generate`
- `camel-jbang-plugin-kubernetes`
- `camel-jbang-plugin-test`
- `camel-kamelet-main`
- `camel-launcher`
- `coverage`
</details>
> :information_source: Shadow mode — Scalpel observes but does not affect test execution. [Learn more](https://github.com/maveniverse/scalpel)
</details>
<details><summary>All tested modules (19 modules, 4m 22s total)</summary>
**Total reactor time:** 4m 22s
| Module | Duration | Status |
| --- | --- | --- |
| Camel :: JBang :: Plugin :: TUI | 51.9s | SUCCESS |
| Camel :: Launcher | 51.1s | SUCCESS |
| Camel :: JBang :: MCP | 43.6s | SUCCESS |
| Camel :: YAML DSL :: Validator | 23.9s | SUCCESS |
| Camel :: YAML DSL | 23.2s | SUCCESS |
| Camel :: JBang :: Plugin :: Kubernetes | 21.2s | SUCCESS |
| Camel :: Kamelet Main | 15.0s | SUCCESS |
| Camel :: JBang :: Plugin :: Testing | 9.0s | SUCCESS |
| Camel :: JBang :: Plugin :: Validate | 6.9s | SUCCESS |
| Camel :: Coverage | 5.1s | SUCCESS |
| Camel :: YAML DSL :: Validator Maven Plugin | 3.0s | SUCCESS |
| Camel :: JBang :: Plugin :: Edit | 1.7s | SUCCESS |
| Camel :: JBang :: Plugin :: Generate | 1.4s | SUCCESS |
| Camel :: JBang :: Integration tests | 1.2s | SUCCESS |
| Camel :: JBang :: Plugin :: MCP | 1.0s | SUCCESS |
| Camel :: JBang :: Plugin :: Route Parser | 1.0s | SUCCESS |
| Camel :: JBang :: Main | 0.9s | SUCCESS |
| Camel :: Launcher :: Container | 0.8s | SUCCESS |
| Camel :: JBang :: Core | n/a | |
**Top 20 slowest modules:**
- `Camel :: JBang :: Plugin :: TUI` (51.9s)
- `Camel :: Launcher` (51.1s)
- `Camel :: JBang :: MCP` (43.6s)
- `Camel :: YAML DSL :: Validator` (23.9s)
- `Camel :: YAML DSL` (23.2s)
- `Camel :: JBang :: Plugin :: Kubernetes` (21.2s)
- `Camel :: Kamelet Main` (15.0s)
- `Camel :: JBang :: Plugin :: Testing` (9.0s)
- `Camel :: JBang :: Plugin :: Validate` (6.9s)
- `Camel :: Coverage` (5.1s)
- `Camel :: YAML DSL :: Validator Maven Plugin` (3.0s)
- `Camel :: JBang :: Plugin :: Edit` (1.7s)
- `Camel :: JBang :: Plugin :: Generate` (1.4s)
- `Camel :: JBang :: Integration tests` (1.2s)
- `Camel :: JBang :: Plugin :: MCP` (1.0s)
- `Camel :: JBang :: Plugin :: Route Parser` (1.0s)
- `Camel :: JBang :: Main` (0.9s)
- `Camel :: Launcher :: Container` (0.8s)
</details>
---
:gear: [View full build and test results](https://github.com/apache/camel/actions/runs/37486057372)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-25380: camel-yaml-dsl - Do not log the compact notation warning for the Kamelets of the Kamelet catalog [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27448:
URL: https://github.com/apache/camel/pull/27448#issuecomment-6020786967
<!-- regen-patch -->
### :warning: Generated files are out of date
The [CI build](https://github.com/apache/camel/actions/runs/37494651708) regenerated files that are not committed on this PR.
If *Allow edits from maintainers* is enabled, a maintainer bot will automatically
push a "Regen" commit to this branch shortly.
Otherwise, you can apply the patch manually — the missing changes are available
as the `regen-patch` artifact of that run:
```bash
gh pr checkout 27448 --repo apache/camel
gh run download 37494651708 --repo apache/camel -n regen-patch
git apply --index regen.patch && rm regen.patch pr-number
git commit -m "Regen" && git push
```
Alternatively, run `./etc/scripts/regen.sh` locally and commit the resulting changes.
If the patch does not apply cleanly, update the branch from the base branch first —
the patch was generated against the merge with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-25380: camel-yaml-dsl - Do not log the compact notation warning for YAML inside a jar [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27448:
URL: https://github.com/apache/camel/pull/27448#issuecomment-6019421899
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
* You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
:warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] CAMEL-25380: camel-yaml-dsl - Do not log the compact notation warning for the Kamelets of the Kamelet catalog [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #27448:
URL: https://github.com/apache/camel/pull/27448#issuecomment-6020560932
Thanks @Croway, agreed: "inside a jar" was the wrong test. Reworked in 7b5cf880f446 to decide by origin, as you suggested:
- **Only the Kamelet catalog is exempt.** Only a file under `kamelets/` in a `camel-kamelets` jar skips the warning. This is matched on the resource location and on its resolved URI, so `classpath:kamelets/...`, a scan of the jar, and a jar nested in a Spring Boot jar are all treated the same.
- Your 1 and 2: the application's own jar and custom Kamelets warn again, whether loaded explicitly or by wildcard.
- Your 3: other archive protocols warn as for any user file.
- **Lazy (your 4):** the check runs inside `warnCompactNotationOnce`, only when a warning is about to be logged. Canonical files never trigger a lookup. The `YamlRoutesBuilderLoaderSupport` change is reverted.
- **Minor points:** the class loader is restored in a `finally`. New tests check that a user's jar and a plain classpath file still warn. `yaml-dsl.adoc` documents the exemption.
_Claude Code on behalf of Claus Ibsen_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org