You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/03/03 07:20:18 UTC

[GitHub] [incubator-doris] EmmyMiao87 opened a new pull request #5445: [Export] Expand function of export stmt

EmmyMiao87 opened a new pull request #5445:
URL: https://github.com/apache/incubator-doris/pull/5445


   ## Proposed changes
   
   1. Support where clause in export stmt which only export selected rows.
   
   The syntax is following:
   
   Export table [table name]
       where [expr]
   To xxx
   xxxx
   
   It will filter table rows.
   Only rows that meet the where condition can be exported.
   
   2. Support utf8 separator
   
   3. Support export to local
   
   The syntax is following:
   
   Export table [table name]
   To (file:///xxx/xx/xx)
   
   If user export rows to local, the broker properties is not requried.
   User only need to create a local folder to store data, and fill in the path of the folder starting with file://
   
   Change-Id: Ib7e7ece5accb3e359a67310b0bf006d42cd3f6f5
   
   ## Types of changes
   
   What types of changes does your code introduce to Doris?
   _Put an `x` in the boxes that apply_
   
   - [] Bugfix (non-breaking change which fixes an issue)
   - [x] New feature (non-breaking change which adds functionality)
   - [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
   - [] Documentation Update (if none of the other choices apply)
   - [] Code refactor (Modify the code structure, format the code, etc...)
   
   ## Checklist
   
   _Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
   
   - [] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
   - [] Compiling and unit tests pass locally with my changes
   - [] I have added tests that prove my fix is effective or that my feature works
   - [] If these changes need document changes, I have updated the document
   - [] Any dependent changes have been merged
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] EmmyMiao87 commented on pull request #5445: [Export] Expand function of export stmt

Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on pull request #5445:
URL: https://github.com/apache/incubator-doris/pull/5445#issuecomment-789502734


   I will update document later.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] EmmyMiao87 merged pull request #5445: [Export] Expand function of export stmt

Posted by GitBox <gi...@apache.org>.
EmmyMiao87 merged pull request #5445:
URL: https://github.com/apache/incubator-doris/pull/5445


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] EmmyMiao87 commented on pull request #5445: [Export] Expand function of export stmt

Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on pull request #5445:
URL: https://github.com/apache/incubator-doris/pull/5445#issuecomment-790391333


   > I will update document later.
   
   Done


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] morningman commented on a change in pull request #5445: [Export] Expand function of export stmt

Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #5445:
URL: https://github.com/apache/incubator-doris/pull/5445#discussion_r589134806



##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/ExportStmt.java
##########
@@ -46,6 +46,8 @@
 import java.util.List;
 import java.util.Map;
 
+import static org.apache.doris.analysis.OutFileClause.LOCAL_FILE_PREFIX;

Review comment:
       Don't using static import

##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/ExportJob.java
##########
@@ -89,6 +99,8 @@
 import java.util.UUID;
 import java.util.concurrent.atomic.AtomicInteger;
 
+import static org.apache.doris.analysis.OutFileClause.LOCAL_FILE_PREFIX;

Review comment:
       static import




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [incubator-doris] EmmyMiao87 commented on a change in pull request #5445: [Export] Expand function of export stmt

Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on a change in pull request #5445:
URL: https://github.com/apache/incubator-doris/pull/5445#discussion_r590067883



##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/ExportStmt.java
##########
@@ -46,6 +46,8 @@
 import java.util.List;
 import java.util.Map;
 
+import static org.apache.doris.analysis.OutFileClause.LOCAL_FILE_PREFIX;

Review comment:
       Ok




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org