You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "VladaZakharova (via GitHub)" <gi...@apache.org> on 2025/04/16 08:28:16 UTC
[PR] Fix install_java.sh script to correctly clear /files/bin folder before reinstalling java [airflow]
VladaZakharova opened a new pull request, #49336:
URL: https://github.com/apache/airflow/pull/49336
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix install_java.sh script to correctly clear /files/bin folder before reinstalling java [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #49336:
URL: https://github.com/apache/airflow/pull/49336#discussion_r2197925447
##########
scripts/in_container/bin/install_java.sh:
##########
@@ -34,7 +43,7 @@ if command -v java; then
exit 1
fi
-DOWNLOAD_URL='https://download.java.net/openjdk/jdk8u41/ri/openjdk-8u41-b04-linux-x64-14_jan_2020.tar.gz'
+DOWNLOAD_URL='https://download.oracle.com/java/23/latest/jdk-23_linux-x64_bin.tar.gz'
Review Comment:
> They may not be distributed
> Apache projects may not distribute Category X licensed components, in source or binary form; in ASF source code or in convenience binaries. As with the previous question on platforms, you can rely on the component if its license terms do not affect the Apache product's licensing. For example, using a GPL'ed tool during the build is okay, but including GPL'ed source code is not.
https://www.apache.org/legal/resolved.html#category-x
##########
scripts/in_container/bin/install_java.sh:
##########
@@ -34,7 +43,7 @@ if command -v java; then
exit 1
fi
-DOWNLOAD_URL='https://download.java.net/openjdk/jdk8u41/ri/openjdk-8u41-b04-linux-x64-14_jan_2020.tar.gz'
+DOWNLOAD_URL='https://download.oracle.com/java/23/latest/jdk-23_linux-x64_bin.tar.gz'
Review Comment:
> # They may not be distributed
>
> Apache projects may not distribute Category X licensed components, in source or binary form; in ASF source code or in convenience binaries. As with the previous question on platforms, you can rely on the component if its license terms do not affect the Apache product's licensing. For example, using a GPL'ed tool during the build is okay, but including GPL'ed source code is not.
https://www.apache.org/legal/resolved.html#category-x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix install_java.sh script to correctly clear /files/bin folder before reinstalling java [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49336:
URL: https://github.com/apache/airflow/pull/49336#issuecomment-3218485066
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix install_java.sh script to correctly clear /files/bin folder before reinstalling java [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #49336: Fix install_java.sh script to correctly clear /files/bin folder before reinstalling java
URL: https://github.com/apache/airflow/pull/49336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix install_java.sh script to correctly clear /files/bin folder before reinstalling java [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on code in PR #49336:
URL: https://github.com/apache/airflow/pull/49336#discussion_r2192664527
##########
scripts/in_container/bin/install_java.sh:
##########
@@ -34,7 +43,7 @@ if command -v java; then
exit 1
fi
-DOWNLOAD_URL='https://download.java.net/openjdk/jdk8u41/ri/openjdk-8u41-b04-linux-x64-14_jan_2020.tar.gz'
+DOWNLOAD_URL='https://download.oracle.com/java/23/latest/jdk-23_linux-x64_bin.tar.gz'
Review Comment:
It happens :)
I'm still conerned regarding the licensing - NFTC doesn't seem to be Apache compatible, so I'm not sure whether we could use it. I'll ask for additional feedback in the Slack channel.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix install_java.sh script to correctly clear /files/bin folder before reinstalling java [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on code in PR #49336:
URL: https://github.com/apache/airflow/pull/49336#discussion_r2192664527
##########
scripts/in_container/bin/install_java.sh:
##########
@@ -34,7 +43,7 @@ if command -v java; then
exit 1
fi
-DOWNLOAD_URL='https://download.java.net/openjdk/jdk8u41/ri/openjdk-8u41-b04-linux-x64-14_jan_2020.tar.gz'
+DOWNLOAD_URL='https://download.oracle.com/java/23/latest/jdk-23_linux-x64_bin.tar.gz'
Review Comment:
It happens :)
I'm still conerned regarding the licensing - NFTC doesn't seem to be Apache compatible, so I'm not sure whether we could use it. Maybe using [JDK 24](https://openjdk.org/projects/jdk/24/) solves it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix install_java.sh script to correctly clear /files/bin folder before reinstalling java [airflow]
Posted by "VladaZakharova (via GitHub)" <gi...@apache.org>.
VladaZakharova closed pull request #49336: Fix install_java.sh script to correctly clear /files/bin folder before reinstalling java
URL: https://github.com/apache/airflow/pull/49336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix install_java.sh script to correctly clear /files/bin folder before reinstalling java [airflow]
Posted by "VladaZakharova (via GitHub)" <gi...@apache.org>.
VladaZakharova commented on PR #49336:
URL: https://github.com/apache/airflow/pull/49336#issuecomment-2897849960
@shahar1 Hi! can you please check this PR?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix install_java.sh script to correctly clear /files/bin folder before reinstalling java [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #49336:
URL: https://github.com/apache/airflow/pull/49336#discussion_r2197920608
##########
scripts/in_container/bin/install_java.sh:
##########
@@ -34,7 +43,7 @@ if command -v java; then
exit 1
fi
-DOWNLOAD_URL='https://download.java.net/openjdk/jdk8u41/ri/openjdk-8u41-b04-linux-x64-14_jan_2020.tar.gz'
+DOWNLOAD_URL='https://download.oracle.com/java/23/latest/jdk-23_linux-x64_bin.tar.gz'
Review Comment:
Yes. We should avoid to use proprietary Java - it's not **crucial** because this is not something we distribute with Airflow - `install_java.sh` is just used in `breeze` to install java dynamically - it's not used in any other place.
So if this will work with later openjdk - let's use openjdk, but if we can't make it happen easily, oracle's java is possible to be used here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix install_java.sh script to correctly clear /files/bin folder before reinstalling java [airflow]
Posted by "VladaZakharova (via GitHub)" <gi...@apache.org>.
VladaZakharova closed pull request #49336: Fix install_java.sh script to correctly clear /files/bin folder before reinstalling java
URL: https://github.com/apache/airflow/pull/49336
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix install_java.sh script to correctly clear /files/bin folder before reinstalling java [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on code in PR #49336:
URL: https://github.com/apache/airflow/pull/49336#discussion_r2192668761
##########
scripts/in_container/bin/install_java.sh:
##########
@@ -34,7 +43,7 @@ if command -v java; then
exit 1
fi
-DOWNLOAD_URL='https://download.java.net/openjdk/jdk8u41/ri/openjdk-8u41-b04-linux-x64-14_jan_2020.tar.gz'
+DOWNLOAD_URL='https://download.oracle.com/java/23/latest/jdk-23_linux-x64_bin.tar.gz'
Review Comment:
@VladaZakharova Also, what was not working in the old distribution?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix install_java.sh script to correctly clear /files/bin folder before reinstalling java [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on code in PR #49336:
URL: https://github.com/apache/airflow/pull/49336#discussion_r2100951018
##########
scripts/in_container/bin/install_java.sh:
##########
@@ -34,7 +43,7 @@ if command -v java; then
exit 1
fi
-DOWNLOAD_URL='https://download.java.net/openjdk/jdk8u41/ri/openjdk-8u41-b04-linux-x64-14_jan_2020.tar.gz'
+DOWNLOAD_URL='https://download.oracle.com/java/23/latest/jdk-23_linux-x64_bin.tar.gz'
Review Comment:
@VladaZakharova Why do we need to change the JDK distribution?
@potiuk is Oracle JDK 23 license (NFTC) Apache-compatible?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix install_java.sh script to correctly clear /files/bin folder before reinstalling java [airflow]
Posted by "VladaZakharova (via GitHub)" <gi...@apache.org>.
VladaZakharova commented on code in PR #49336:
URL: https://github.com/apache/airflow/pull/49336#discussion_r2189989775
##########
scripts/in_container/bin/install_java.sh:
##########
@@ -34,7 +43,7 @@ if command -v java; then
exit 1
fi
-DOWNLOAD_URL='https://download.java.net/openjdk/jdk8u41/ri/openjdk-8u41-b04-linux-x64-14_jan_2020.tar.gz'
+DOWNLOAD_URL='https://download.oracle.com/java/23/latest/jdk-23_linux-x64_bin.tar.gz'
Review Comment:
Oh hi, sorry, I missed the message:)
this is (was) the latest one, and on old one it was not working
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix install_java.sh script to correctly clear /files/bin folder before reinstalling java [airflow]
Posted by "shahar1 (via GitHub)" <gi...@apache.org>.
shahar1 commented on code in PR #49336:
URL: https://github.com/apache/airflow/pull/49336#discussion_r2192664527
##########
scripts/in_container/bin/install_java.sh:
##########
@@ -34,7 +43,7 @@ if command -v java; then
exit 1
fi
-DOWNLOAD_URL='https://download.java.net/openjdk/jdk8u41/ri/openjdk-8u41-b04-linux-x64-14_jan_2020.tar.gz'
+DOWNLOAD_URL='https://download.oracle.com/java/23/latest/jdk-23_linux-x64_bin.tar.gz'
Review Comment:
It happens :)
I'm still conerned regarding the licensing - NFTC doesn't seem to be Apache compatible, so I'm not sure whether we could use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix install_java.sh script to correctly clear /files/bin folder before reinstalling java [airflow]
Posted by "VladaZakharova (via GitHub)" <gi...@apache.org>.
VladaZakharova commented on code in PR #49336:
URL: https://github.com/apache/airflow/pull/49336#discussion_r2197165162
##########
scripts/in_container/bin/install_java.sh:
##########
@@ -34,7 +43,7 @@ if command -v java; then
exit 1
fi
-DOWNLOAD_URL='https://download.java.net/openjdk/jdk8u41/ri/openjdk-8u41-b04-linux-x64-14_jan_2020.tar.gz'
+DOWNLOAD_URL='https://download.oracle.com/java/23/latest/jdk-23_linux-x64_bin.tar.gz'
Review Comment:
I am honestly not sure about the licence
On the old version Apache Beam operators for java were not working
I will test with this openJDK that you have shared and maybe we can use the free one :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix install_java.sh script to correctly clear /files/bin folder before reinstalling java [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #49336:
URL: https://github.com/apache/airflow/pull/49336#issuecomment-3040476956
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org