You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by richard zhou <ri...@intel.com> on 2015/01/06 09:08:03 UTC
Re: Review Request 29619: SQOOP-1961: addDelegationTokens is not
exposed in SqoopClient
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29619/
-----------------------------------------------------------
(Updated Jan. 6, 2015, 8:08 a.m.)
Review request for Sqoop and Jerry Chen.
Summary (updated)
-----------------
SQOOP-1961: addDelegationTokens is not exposed in SqoopClient
Repository: sqoop-sqoop2
Description
-------
addDelegationTokens is not exposed in SqoopClient
Diffs
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java e1f009cd517caa139a5525735df2c980a2e75d5e
client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java fe528f26e0bbc9411ae0b37b0b2c3f4ebe19634c
Diff: https://reviews.apache.org/r/29619/diff/
Testing
-------
local test
Thanks,
richard zhou
Re: Review Request 29619: SQOOP-1961: addDelegationTokens is not
exposed in SqoopClient
Posted by richard zhou <ri...@intel.com>.
> On Jan. 6, 2015, 10:44 p.m., Abraham Elmahrek wrote:
> > client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java, lines 52-58
> > <https://reviews.apache.org/r/29619/diff/1/?file=807588#file807588line52>
> >
> > I think you need to hit each request separately, other wise they won't have the proper delegation token?
Talked with Abe offline, and this issue is handled in SQOOP-1960.
- richard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29619/#review66883
-----------------------------------------------------------
On Jan. 6, 2015, 8:08 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29619/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2015, 8:08 a.m.)
>
>
> Review request for Sqoop and Jerry Chen.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> addDelegationTokens is not exposed in SqoopClient
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java e1f009cd517caa139a5525735df2c980a2e75d5e
> client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java fe528f26e0bbc9411ae0b37b0b2c3f4ebe19634c
>
> Diff: https://reviews.apache.org/r/29619/diff/
>
>
> Testing
> -------
>
> local test
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 29619: SQOOP-1961: addDelegationTokens is not
exposed in SqoopClient
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29619/#review66883
-----------------------------------------------------------
client/src/main/java/org/apache/sqoop/client/SqoopClient.java
<https://reviews.apache.org/r/29619/#comment110580>
Have you checked with Oozie to make sure that this API will work? I know that they use Hadoop token files to manage a lot of this.
client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java
<https://reviews.apache.org/r/29619/#comment110659>
I think you need to hit each request separately, other wise they won't have the proper delegation token?
- Abraham Elmahrek
On Jan. 6, 2015, 8:08 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29619/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2015, 8:08 a.m.)
>
>
> Review request for Sqoop and Jerry Chen.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> addDelegationTokens is not exposed in SqoopClient
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java e1f009cd517caa139a5525735df2c980a2e75d5e
> client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java fe528f26e0bbc9411ae0b37b0b2c3f4ebe19634c
>
> Diff: https://reviews.apache.org/r/29619/diff/
>
>
> Testing
> -------
>
> local test
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 29619: SQOOP-1961: addDelegationTokens is not
exposed in SqoopClient
Posted by Abraham Elmahrek <ab...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29619/#review71115
-----------------------------------------------------------
Ship it!
Ship It!
- Abraham Elmahrek
On Feb. 4, 2015, 2:49 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29619/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 2:49 a.m.)
>
>
> Review request for Sqoop and Jerry Chen.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> addDelegationTokens is not exposed in SqoopClient
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java 612f97be669a6351ba415f69043613c1314bb7ce
> client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java adb2c474f617be935eb5fdb280cfda0c28279c1a
>
> Diff: https://reviews.apache.org/r/29619/diff/
>
>
> Testing
> -------
>
> local test
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 29619: SQOOP-1961: addDelegationTokens is not
exposed in SqoopClient
Posted by Jerry Chen <ha...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29619/#review70916
-----------------------------------------------------------
Ship it!
Ship It!
- Jerry Chen
On Feb. 4, 2015, 2:49 a.m., richard zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29619/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 2:49 a.m.)
>
>
> Review request for Sqoop and Jerry Chen.
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> addDelegationTokens is not exposed in SqoopClient
>
>
> Diffs
> -----
>
> client/src/main/java/org/apache/sqoop/client/SqoopClient.java 612f97be669a6351ba415f69043613c1314bb7ce
> client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java adb2c474f617be935eb5fdb280cfda0c28279c1a
>
> Diff: https://reviews.apache.org/r/29619/diff/
>
>
> Testing
> -------
>
> local test
>
>
> Thanks,
>
> richard zhou
>
>
Re: Review Request 29619: SQOOP-1961: addDelegationTokens is not
exposed in SqoopClient
Posted by richard zhou <ri...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29619/
-----------------------------------------------------------
(Updated Feb. 4, 2015, 2:49 a.m.)
Review request for Sqoop and Jerry Chen.
Repository: sqoop-sqoop2
Description
-------
addDelegationTokens is not exposed in SqoopClient
Diffs (updated)
-----
client/src/main/java/org/apache/sqoop/client/SqoopClient.java 612f97be669a6351ba415f69043613c1314bb7ce
client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java adb2c474f617be935eb5fdb280cfda0c28279c1a
Diff: https://reviews.apache.org/r/29619/diff/
Testing
-------
local test
Thanks,
richard zhou