You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2021/03/01 22:13:28 UTC

[GitHub] [cordova-common] raphinesse opened a new pull request #160: refactor(xml-helpers): document & check function signature types 

raphinesse opened a new pull request #160:
URL: https://github.com/apache/cordova-common/pull/160


   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   This PR adds type documentation to the `util/xml-helpers` module to more clearly document the interface of the module.
   
   The types correctness can be checked using TypeScript tooling
   
   ### Description
   <!-- Describe your changes in detail -->
   - use ES6 method syntax (because VSCode generated a nicer starting point that way)
   - document & check function signature types
   - satisfy TS type checks: in a few cases our code was not 100% in line with the `elementtree` types. However both the old and new version should behave identically with regards to our use-cases
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   Checked type correctness of module using VSCode
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-common] raphinesse commented on pull request #160: refactor(xml-helpers): document & check function signature types

Posted by GitBox <gi...@apache.org>.
raphinesse commented on pull request #160:
URL: https://github.com/apache/cordova-common/pull/160#issuecomment-856597799


   Last call for reviews or objections.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-common] raphinesse merged pull request #160: refactor(xml-helpers): document & check function signature types

Posted by GitBox <gi...@apache.org>.
raphinesse merged pull request #160:
URL: https://github.com/apache/cordova-common/pull/160


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org