You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2021/11/11 03:55:40 UTC

[GitHub] [dolphinscheduler] kezhenxu94 commented on a change in pull request #6786: [Improvement][Datasource]refactor datasource parsing other parameter

kezhenxu94 commented on a change in pull request #6786:
URL: https://github.com/apache/dolphinscheduler/pull/6786#discussion_r747183299



##########
File path: dolphinscheduler-datasource-plugin/dolphinscheduler-datasource-api/src/main/java/org/apache/dolphinscheduler/plugin/datasource/api/datasource/AbstractDatasourceProcessor.java
##########
@@ -86,4 +91,59 @@ public String getDatasourceUniqueId(ConnectionParam connectionParam, DbType dbTy
         BaseConnectionParam baseConnectionParam = (BaseConnectionParam) connectionParam;
         return MessageFormat.format("{0}@{1}@{2}", dbType.getDescp(), baseConnectionParam.getUser(), baseConnectionParam.getJdbcUrl());
     }
+
+    /**
+     * transform other
+     *
+     * @param type type
+     * @param otherMap otherMap
+     */

Review comment:
       This kind of JavaDoc is meaningless, please remove them or write more meaningful JavaDoc




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org