You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kylin.apache.org by pengjianhua <pe...@zte.com.cn> on 2017/09/15 06:43:28 UTC

Review Request 62346: KYLIN-2870 Shortcut key description is error at Kylin-Web

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62346/
-----------------------------------------------------------

Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu.


Bugs: KYLIN-2870
    https://issues.apache.org/jira/browse/KYLIN-2870


Repository: kylin


Description
-------

Shortcut key description is error at Kylin-Web?when i click Ctrl+Shift+Space to create a sql.
Please see 1.jpg.


Diffs
-----

  webapp/app/partials/query/query.html 894113e0d 


Diff: https://reviews.apache.org/r/62346/diff/1/


Testing
-------


Thanks,

pengjianhua


Re: Review Request 62346: KYLIN-2870 Shortcut key description is error at Kylin-Web

Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62346/
-----------------------------------------------------------

(Updated 九月 21, 2017, 9:29 a.m.)


Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu.


Bugs: KYLIN-2870
    https://issues.apache.org/jira/browse/KYLIN-2870


Repository: kylin


Description
-------

Shortcut key description is error at Kylin-Web when I click Ctrl+Shift+Space to create a sql.
The current tips is as following:
Tips: Ctrl+Shift+Space or Alt+Space(Windows), Command+Option+Space(Mac) to list table/columns in query box.

In fact, The keywords will be list when we press Alt+Space in windows. Please refer to 1.jpg.

So the right tips should be as following:
Ctrl+Shift+Space or Alt+Space(Windows), Command+Option+Space(Mac) to list keywords in query box.

Please see 1.jpg.


Diffs (updated)
-----

  webapp/app/partials/query/query.html 894113e0d 


Diff: https://reviews.apache.org/r/62346/diff/4/

Changes: https://reviews.apache.org/r/62346/diff/3-4/


Testing
-------


Thanks,

pengjianhua


Re: Review Request 62346: KYLIN-2870 Shortcut key description is error at Kylin-Web

Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62346/
-----------------------------------------------------------

(Updated 九月 21, 2017, 9:27 a.m.)


Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu.


Bugs: KYLIN-2870
    https://issues.apache.org/jira/browse/KYLIN-2870


Repository: kylin


Description (updated)
-------

Shortcut key description is error at Kylin-Web when I click Ctrl+Shift+Space to create a sql.
The current tips is as following:
Tips: Ctrl+Shift+Space or Alt+Space(Windows), Command+Option+Space(Mac) to list table/columns in query box.

In fact, The keywords will be list when we press Alt+Space in windows. Please refer to 1.jpg.

So the right tips should be as following:
Ctrl+Shift+Space or Alt+Space(Windows), Command+Option+Space(Mac) to list keywords in query box.

Please see 1.jpg.


Diffs
-----

  webapp/app/partials/query/query.html 894113e0d 


Diff: https://reviews.apache.org/r/62346/diff/3/


Testing
-------


Thanks,

pengjianhua


Re: Review Request 62346: KYLIN-2870 Shortcut key description is error at Kylin-Web

Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62346/
-----------------------------------------------------------

(Updated 九月 21, 2017, 9:26 a.m.)


Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu.


Bugs: KYLIN-2870
    https://issues.apache.org/jira/browse/KYLIN-2870


Repository: kylin


Description (updated)
-------

Shortcut key description is error at Kylin-Web when I click Ctrl+Shift+Space to create a sql.
The current tips is as following:
Tips: Ctrl+Shift+Space or Alt+Space(Windows), Command+Option+Space(Mac) to list table/columns in query box.

In fact, The keykwords will be list when we press Alt+Space in windows. Please refer to 1.jpg.

So the right tips should be as following:
Ctrl+Shift+Space or Alt+Space(Windows), Command+Option+Space(Mac) to list keywords in query box.

Please see 1.jpg.


Diffs
-----

  webapp/app/partials/query/query.html 894113e0d 


Diff: https://reviews.apache.org/r/62346/diff/3/


Testing
-------


Thanks,

pengjianhua


Re: Review Request 62346: KYLIN-2870 Shortcut key description is error at Kylin-Web

Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62346/
-----------------------------------------------------------

(Updated 九月 21, 2017, 9:22 a.m.)


Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu.


Bugs: KYLIN-2870
    https://issues.apache.org/jira/browse/KYLIN-2870


Repository: kylin


Description
-------

Shortcut key description is error at Kylin-Web when I click Ctrl+Shift+Space to create a sql.
The current tips is as following:
Tips: Ctrl+Shift+Space or Alt+Space(Windows), Command+Option+Space(Mac) to list table/columns in query box.

In fact, The keykwords will be list when we press Alt+Space in windows. Please refer to 1.jpg.

So the right tips should be as following:
Ctrl+Shift+Space or Alt+Space(Windows), Command+Option+Space(Mac) to list keykwords in query box.

Please see 1.jpg.


Diffs (updated)
-----

  webapp/app/partials/query/query.html 894113e0d 


Diff: https://reviews.apache.org/r/62346/diff/3/

Changes: https://reviews.apache.org/r/62346/diff/2-3/


Testing
-------


Thanks,

pengjianhua


Re: Review Request 62346: KYLIN-2870 Shortcut key description is error at Kylin-Web

Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62346/
-----------------------------------------------------------

(Updated 九月 21, 2017, 8:59 a.m.)


Review request for kylin, Dayue Gao, Dong Li, hongbin ma, and Wang Xiaoyu.


Bugs: KYLIN-2870
    https://issues.apache.org/jira/browse/KYLIN-2870


Repository: kylin


Description (updated)
-------

Shortcut key description is error at Kylin-Web when I click Ctrl+Shift+Space to create a sql.
The current tips is as following:
Tips: Ctrl+Shift+Space or Alt+Space(Windows), Command+Option+Space(Mac) to list table/columns in query box.

In fact, The keykwords will be list when we press Alt+Space in windows. Please refer to 1.jpg.

So the right tips should be as following:
Ctrl+Shift+Space or Alt+Space(Windows), Command+Option+Space(Mac) to list keykwords in query box.

Please see 1.jpg.


Diffs
-----

  webapp/app/partials/query/query.html 894113e0d 


Diff: https://reviews.apache.org/r/62346/diff/2/


Testing
-------


Thanks,

pengjianhua