You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jspwiki.apache.org by "Bertram Nudelbach (JIRA)" <ji...@apache.org> on 2012/06/19 14:35:43 UTC

[jira] [Created] (JSPWIKI-734) ShortURLConstructor causes Syntax Error when loading jspwiki-edit.js

Bertram Nudelbach created JSPWIKI-734:
-----------------------------------------

             Summary: ShortURLConstructor causes Syntax Error when loading jspwiki-edit.js
                 Key: JSPWIKI-734
                 URL: https://issues.apache.org/jira/browse/JSPWIKI-734
             Project: JSPWiki
          Issue Type: Bug
          Components: Core & storage
    Affects Versions: 2.8.4
         Environment: FF 13.1 - Windows - Tomcat 7.0.27
            Reporter: Bertram Nudelbach


I tried using {{jspwiki.urlConstructor = ShortURLConstructor}} and it took me a quite amount of time to see that this causes a problem:

The editor toolbar is not working anymore, the quick preview under the editing text area eighter.
The web console of firefox shows that there is a syntax error in line 13 in {{jspwiki-edit.js}}.

The line highlighted is:

{{<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">}}

Using the {{ShortViewURLConstructor}} or the default "fixes" the problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (JSPWIKI-734) ShortURLConstructor causes Syntax Error when loading jspwiki-edit.js

Posted by "Florian Holeczek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JSPWIKI-734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Florian Holeczek updated JSPWIKI-734:
-------------------------------------

    Fix Version/s:     (was: Graduating)
    
> ShortURLConstructor causes Syntax Error when loading jspwiki-edit.js
> --------------------------------------------------------------------
>
>                 Key: JSPWIKI-734
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-734
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Core & storage
>    Affects Versions: 2.8.4, 2.9
>         Environment: FF 13.1 - Windows - Tomcat 7.0.27
>            Reporter: Bertram Nudelbach
>             Fix For: 2.9
>
>
> I tried using {{jspwiki.urlConstructor = ShortURLConstructor}} and it took me a quite amount of time to see that this causes a problem:
> The editor toolbar is not working anymore, the quick preview under the editing text area eighter.
> The web console of firefox shows that there is a syntax error in line 13 in {{jspwiki-edit.js}}.
> The line highlighted is:
> {{<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">}}
> Using the {{ShortViewURLConstructor}} or the default "fixes" the problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (JSPWIKI-734) ShortURLConstructor causes Syntax Error when loading jspwiki-edit.js

Posted by "brushed (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/JSPWIKI-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13397043#comment-13397043 ] 

brushed commented on JSPWIKI-734:
---------------------------------


The editor includes 2 javascript resources, by using addResourceRequests call in plain.jsp.
However, the path's should be encoded properly, depending on the correct url constructor scheme.


Fix plain.jsp.  (also fix FCK.jsp)


Old code:
{code}
   TemplateManager.addResourceRequest( context, TemplateManager.RESOURCE_SCRIPT, "scripts/jspwiki-edit.js" );
   TemplateManager.addResourceRequest( context, TemplateManager.RESOURCE_SCRIPT, "scripts/posteditor.js" );
{code}
New code:

{code}
   TemplateManager.addResourceRequest( context, TemplateManager.RESOURCE_SCRIPT, 
   		context.getURL( WikiContext.NONE, "scripts/jspwiki-edit.js" ) );
   TemplateManager.addResourceRequest( context, TemplateManager.RESOURCE_SCRIPT, 
   		context.getURL( WikiContext.NONE, "scripts/posteditor.js" ) );
{code}


dirk
                
> ShortURLConstructor causes Syntax Error when loading jspwiki-edit.js
> --------------------------------------------------------------------
>
>                 Key: JSPWIKI-734
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-734
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Core & storage
>    Affects Versions: 2.8.4, 2.9
>         Environment: FF 13.1 - Windows - Tomcat 7.0.27
>            Reporter: Bertram Nudelbach
>
> I tried using {{jspwiki.urlConstructor = ShortURLConstructor}} and it took me a quite amount of time to see that this causes a problem:
> The editor toolbar is not working anymore, the quick preview under the editing text area eighter.
> The web console of firefox shows that there is a syntax error in line 13 in {{jspwiki-edit.js}}.
> The line highlighted is:
> {{<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">}}
> Using the {{ShortViewURLConstructor}} or the default "fixes" the problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (JSPWIKI-734) ShortURLConstructor causes Syntax Error when loading jspwiki-edit.js

Posted by "brushed (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JSPWIKI-734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

brushed resolved JSPWIKI-734.
-----------------------------

       Resolution: Fixed
    Fix Version/s: 2.9
                   Graduating

fixed in 2.9.0-incubating-5
                
> ShortURLConstructor causes Syntax Error when loading jspwiki-edit.js
> --------------------------------------------------------------------
>
>                 Key: JSPWIKI-734
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-734
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Core & storage
>    Affects Versions: 2.8.4, 2.9
>         Environment: FF 13.1 - Windows - Tomcat 7.0.27
>            Reporter: Bertram Nudelbach
>             Fix For: Graduating, 2.9
>
>
> I tried using {{jspwiki.urlConstructor = ShortURLConstructor}} and it took me a quite amount of time to see that this causes a problem:
> The editor toolbar is not working anymore, the quick preview under the editing text area eighter.
> The web console of firefox shows that there is a syntax error in line 13 in {{jspwiki-edit.js}}.
> The line highlighted is:
> {{<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">}}
> Using the {{ShortViewURLConstructor}} or the default "fixes" the problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (JSPWIKI-734) ShortURLConstructor causes Syntax Error when loading jspwiki-edit.js

Posted by "brushed (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JSPWIKI-734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

brushed updated JSPWIKI-734:
----------------------------

    Affects Version/s: 2.9
    
> ShortURLConstructor causes Syntax Error when loading jspwiki-edit.js
> --------------------------------------------------------------------
>
>                 Key: JSPWIKI-734
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-734
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Core & storage
>    Affects Versions: 2.8.4, 2.9
>         Environment: FF 13.1 - Windows - Tomcat 7.0.27
>            Reporter: Bertram Nudelbach
>
> I tried using {{jspwiki.urlConstructor = ShortURLConstructor}} and it took me a quite amount of time to see that this causes a problem:
> The editor toolbar is not working anymore, the quick preview under the editing text area eighter.
> The web console of firefox shows that there is a syntax error in line 13 in {{jspwiki-edit.js}}.
> The line highlighted is:
> {{<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">}}
> Using the {{ShortViewURLConstructor}} or the default "fixes" the problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Closed] (JSPWIKI-734) ShortURLConstructor causes Syntax Error when loading jspwiki-edit.js

Posted by "Florian Holeczek (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/JSPWIKI-734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Florian Holeczek closed JSPWIKI-734.
------------------------------------


Closing this, since 2.9 has been released
                
> ShortURLConstructor causes Syntax Error when loading jspwiki-edit.js
> --------------------------------------------------------------------
>
>                 Key: JSPWIKI-734
>                 URL: https://issues.apache.org/jira/browse/JSPWIKI-734
>             Project: JSPWiki
>          Issue Type: Bug
>          Components: Core & storage
>    Affects Versions: 2.8.4, 2.9
>         Environment: FF 13.1 - Windows - Tomcat 7.0.27
>            Reporter: Bertram Nudelbach
>             Fix For: 2.9
>
>
> I tried using {{jspwiki.urlConstructor = ShortURLConstructor}} and it took me a quite amount of time to see that this causes a problem:
> The editor toolbar is not working anymore, the quick preview under the editing text area eighter.
> The web console of firefox shows that there is a syntax error in line 13 in {{jspwiki-edit.js}}.
> The line highlighted is:
> {{<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">}}
> Using the {{ShortViewURLConstructor}} or the default "fixes" the problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira