You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/16 18:19:14 UTC
[GitHub] [nuttx] acassis commented on a diff in pull request #8152: Tm4 c1294 can char dev
acassis commented on code in PR #8152:
URL: https://github.com/apache/nuttx/pull/8152#discussion_r1071498054
##########
boards/arm/tiva/tm4c1294-launchpad/src/tm4c1294-launchpad.h:
##########
@@ -77,6 +77,9 @@
# undef HAVE_I2CTOOL
#endif
+/* Define the procfs mounting point */
+#define TIVA_PROCFS_MOUNTPOINT "/proc"
Review Comment:
Please add empty line after comment line
##########
boards/arm/tiva/tm4c1294-launchpad/Kconfig:
##########
@@ -72,4 +72,46 @@ config TM4C1294_LAUNCHPAD_TIMER_ALTCLK
endif # TM4C1294_LAUNCHPAD_TIMER
endif # TIVA_TIMER32_PERIODIC
+config TM4C1294_LAUNCHPAD_JUMPERS_CAN
+ bool "Use CAN jumpers configuration"
+ default n
+ select TIVA_UART2
+ ---help---
+ If set, Nuttx will assume the jumpers JP4 and JP5 are set in CAN configuration.
Review Comment:
```suggestion
If set, NuttX will assume the jumpers JP4 and JP5 are set in CAN configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org