You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "RanaPriyansh (via GitHub)" <gi...@apache.org> on 2026/10/08 15:13:07 UTC
[PR] Test external CryptoProvider integration through public S3 APIs [arrow-rs-object-store]
RanaPriyansh opened a new pull request, #873:
URL: https://github.com/apache/arrow-rs-object-store/pull/873
# Which issue does this PR close?
Related to #760. This PR covers external-provider integration tests.
# Rationale for this change
Existing provider tests do not show that an external implementation works through the public object_store client API.
# What changes are included in this PR?
Add a separate downstream test crate with an external Ring provider and an in-memory HTTP connector.
Capture a signed PUT through the public AWS client and compare its signature with independent Ring operations.
Check digest and HMAC failure propagation, custom-provider selection, bundled-provider fallback, and `aws-base` without a provider.
Add CI commands for the separate crate. The fixture makes no cloud requests.
Validation on Ubuntu 24.04 with Rust 1.97.0:
- All 15 provider cases pass across three configurations.
- Root default tests pass 135 cases, with three ignored.
- Root Ring tests pass 271 cases, with six ignored.
- All three fixture and eight root Clippy commands pass with warnings denied.
- Formatting, current spelling, and source/lock integrity checks pass.
The [first job](https://github.com/RanaPriyansh/arrow-rs-object-store/actions/runs/37794749507) passed tests and Clippy but failed spelling with typos 1.37.0 on four unchanged identifiers.
The [continuation](https://github.com/RanaPriyansh/arrow-rs-object-store/actions/runs/37797759761) passed formatting, typos 1.51.1, and source/lock integrity.
Its additional dependency audit failed because Cargo's [CLI feature resolution](https://github.com/rust-lang/cargo/blob/c980f4866/src/cargo/ops/resolve.rs#L226-L236) adds nine TLS packages outside the persisted workspace lock.
Their recorded versions match the first job's compilation log. Both job failures remain visible.
# Are there any user-facing changes?
No public API changes.
Codex used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test external CryptoProvider integration through public S3 APIs [arrow-rs-object-store]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #873:
URL: https://github.com/apache/arrow-rs-object-store/pull/873#issuecomment-6224909416
You have many PRs open: https://github.com/apache/arrow-rs-object-store/pulls?q=is%3Apr+state%3Aopen+author%3ARanaPriyansh
Which one do you think is the most imporant to review first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test external CryptoProvider integration through public S3 APIs [arrow-rs-object-store]
Posted by "RanaPriyansh (via GitHub)" <gi...@apache.org>.
RanaPriyansh commented on PR #873:
URL: https://github.com/apache/arrow-rs-object-store/pull/873#issuecomment-6246666038
Please review #861 first. It fixes the GCS upload credential fetch reported in #520 when `skip_signature=true`.
The production change replaces two lines with existing helpers. The regression checks credential calls and Authorization headers with signing enabled and disabled. The public API is unchanged.
The other PRs can remain drafts while this one receives review.
Codex used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test external CryptoProvider integration through public S3 APIs [arrow-rs-object-store]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #873:
URL: https://github.com/apache/arrow-rs-object-store/pull/873#issuecomment-6224926472
Marking as draft per https://github.com/apache/arrow-rs-object-store/pull/873#issuecomment-6224909416 so i can find the PRs that need attention. Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test external CryptoProvider integration through public S3 APIs [arrow-rs-object-store]
Posted by "alamb (via GitHub) via github" <gi...@arrow.apache.org>.
alamb commented on PR #873:
URL: https://github.com/apache/arrow-rs-object-store/pull/873#issuecomment-6558315541
Thank you for the contribution. The change may well be correct, but I am closing this PR under the arrow-rs guidance on AI generated submissions: https://github.com/apache/arrow-rs/blob/main/CONTRIBUTING.md#ai-generated-submissions
Maintainer review time is the scarcest resource in this project. This account has opened more than 80 PRs across many repositories since October 1, and currently has 9 PRs open in object_store totaling roughly 3,900 added lines for maintainers to review:
- #873 Test external CryptoProvider integration through public S3 APIs (+481/-0)
- #869 Test downstream HTTP and crypto configurations (+671/-41)
- #867 fix: validate Azure delegation key coverage (+544/-89)
- #866 fix: honor fsync for local deletes (+175/-16)
- #861 fix: honor GCS skip_signature during uploads (+85/-2)
- #860 GCP: Request uncompressed credential and signing responses (+904/-3)
- #859 test: cover local filesystem put and delete errors (+110/-0)
- #858 fix: accept complete HTTP responses for full ranges (+589/-24)
- #857 fix: preserve typed errors for S3 and GCS list requests (+348/-2)
That volume is far more than we can review. As discussed in #873, we will focus on #861 and I am closing the other draft PRs.
If one of these changes matters to you after #861 is resolved, please open a focused PR with a short description in your own words, one you have reviewed and understand, and we'd be happy to help with review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Test external CryptoProvider integration through public S3 APIs [arrow-rs-object-store]
Posted by "alamb (via GitHub) via github" <gi...@arrow.apache.org>.
alamb closed pull request #873: Test external CryptoProvider integration through public S3 APIs
URL: https://github.com/apache/arrow-rs-object-store/pull/873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org